Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to schedule all reports, even for once #3840

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

Rieven
Copy link
Contributor

@Rieven Rieven commented Nov 14, 2024

Changes

Issue link

#3753

Closes #3753

Demo

image

image

QA notes

You will need to restart the report runner.


Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.


Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@Rieven Rieven requested a review from a team as a code owner November 14, 2024 15:25
ammar92
ammar92 previously approved these changes Nov 15, 2024
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looks good to me 👍 The PR is quite detailed, thanks for that. Just a small note for the next time: please remove the boilerplate text (in the "Issue link" section, either fill it in or remove the section entirely)

@ammar92
Copy link
Contributor

ammar92 commented Nov 15, 2024

There's still an issue with the tests. Apparently a ReportRecipe.cron_expression doesn't like None objects

@Rieven
Copy link
Contributor Author

Rieven commented Nov 15, 2024

There's still an issue with the tests. Apparently a ReportRecipe.cron_expression doesn't like None objects

Yes, this will be fixed probably when the Pr of JP is merged with main, also the test fix :)

@RomijnHumanoids
Copy link

RomijnHumanoids commented Nov 18, 2024

As mentioned in the meeting just now, this suggestion actually matches previous design of selecting the start date for reports 👍. I've provided a screenshot in this comment.
Screenshot 2024-11-18 at 13 03 33

@Rieven
Copy link
Contributor Author

Rieven commented Nov 18, 2024

As mentioned in the meeting just now, this suggestion actually matches previous design of selecting the start date for reports 👍. I've provided a screenshot in this comment. Screenshot 2024-11-18 at 13 03 33

We continue with implementation of time widget as per:
#3809

@Rieven Rieven self-assigned this Nov 18, 2024
@Rieven Rieven marked this pull request as draft November 18, 2024 15:35
@Rieven Rieven marked this pull request as ready for review November 28, 2024 15:53
@stephanie0x00
Copy link
Contributor

stephanie0x00 commented Dec 16, 2024

What works

  • Exporting schedule to PDF and json (onboarding)
  • Opening onboarding report
  • Scheduled a 'no recurrence' report for a few minutes in the future, which got executed as expected. The report can be opened from the History and Scheduled tab.
  • Subreports can be opened.
  • Scheduled with an interval, the report can also be opened.
  • Multiple and single reports can be renamed and deleted.

Questions

  1. The onboarding report is not added to the scheduled report list. Is this intended?

  2. When you set the timestamp to something non-existing (eg: 25:25) the interface accepts this and 'generates' a report. There is no check on whether the set time is valid. This unexpected timestamp report is not added to the Scheduled or History pages.
    image

  3. The layout of the Scheduled and History pages is a bit different. The History tab has extra white space. Is this intended behaviour?

image

Extra spacing on History tab:

image

Copy link

sonarcloud bot commented Dec 16, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
54.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implementation: As a user I want to set a start date of one-time report
7 participants