Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styling fixes on reports page, scheduled tab #3896

Closed
RomijnHumanoids opened this issue Nov 27, 2024 · 0 comments · Fixed by #3930
Closed

Styling fixes on reports page, scheduled tab #3896

RomijnHumanoids opened this issue Nov 27, 2024 · 0 comments · Fixed by #3930
Assignees
Labels

Comments

@RomijnHumanoids
Copy link

RomijnHumanoids commented Nov 27, 2024

Two things (needing styling fixes) stand out in the current implementation of the reports page, scheduled tab in the main branch:

  • Report type tags in table cells miss padding in width. This padding should be 8px (0.5rem) on both sides.
    Image

  • The leading icon of the button for 'edit recipe' is out of place, it seems like it is put on a different text line instead of next to the text (like in other buttons).
    Image

  • Also, the expandable rows button cell on the right is not "sticky" over the other cells in case of a horizontal scroll. Can we implement this here too like we see in the Findings list for example?
    Image
    Image
    Desired behaviour:
    Image

@RomijnHumanoids RomijnHumanoids converted this from a draft issue Nov 27, 2024
@TwistMeister TwistMeister moved this from Backlog / To do to In Progress in KAT Nov 27, 2024
@TwistMeister TwistMeister moved this from In Progress to Review in KAT Dec 3, 2024
@ammar92 ammar92 moved this from Review to QA review / functional testing in KAT Dec 4, 2024
@ammar92 ammar92 moved this from QA review / functional testing to Ready for merge in KAT Dec 4, 2024
@github-project-automation github-project-automation bot moved this from Ready for merge to Done in KAT Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants