Fix octopoes typing #2555

dekkers · 2024-02-23T16:53:12Z

Changes

This fixes all typing in Octopoes.

Issue link

#2116 (Almost done, only boefjes plugins directory still needs to be done)

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

octopoes/.ci/docker-compose.yml

octopoes/bits/spf_discovery/spf_discovery.py

octopoes/octopoes/api/models.py

octopoes/octopoes/events/events.py

octopoes/octopoes/core/service.py

octopoes/octopoes/xtdb/query.py

octopoes/tests/robot/03_deletion_propagation.robot

ammar92

Very nice stuff. Just a few remarks/ questions, but consider it approved

octopoes/.ci/docker-compose.yml

octopoes/octopoes/api/models.py

octopoes/octopoes/models/path.py

rocky/reports/report_types/name_server_report/report.py

stephanie0x00 · 2024-02-28T12:43:39Z

Checklist for QA:

I have checked out this branch, and successfully ran a fresh make reset.
I confirmed that there are no unintended functional regressions in this branch:
- I have managed to pass the onboarding flow
- Objects and Findings are created properly
- Tasks are created and completed properly
I confirmed that the PR's advertised feature or hotfix works as intended.

What works:

Nicely done. Things seem to work as expected: objects can be added and are created, boefjes can be enabled and run accordingly, tasks complete and reports seem to generate too.

What doesn't work:

n/a

Bug or feature?:

n/a

* main: (85 commits) Fix wrong solving of merge conflict (#2585) Add metrics collection for scheduler using prometheus (#2468) Hotfix for where_in queries for abstract types (#2577) Update django (#2587) Fix octopoes typing (#2555) Create findings report (#2393) Raise exception if boefje input OOI has been deleted (#2573) Set a timeout on hanging test ssl container (#2560) Feature/efficient reporting (#2516) Updated findings database. Removed old findings, added Impact, Source… (#2569) add unit test for web report (#2528) Add pool size config and logs (#2541) Quick fix for PDF table overflow (#2562) Fix/2527 octopoes unicode (#2558) Add return typing to report test fixtures (#2557) Sort vulnerabilities in vulnerability report (#2378) Disable ruff split-on-trailing-comma and update ruff (#2544) Select all oois triggers toggle all (#2536) Remove unnecessary toplevel dependencies (#2554) Make valid time required parameter in the octopoes API (#2543) ...

dekkers requested a review from a team as a code owner February 23, 2024 16:53