Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use mypy in boefjes, octopoes and rocky #2116

Closed
dekkers opened this issue Dec 11, 2023 · 0 comments · Fixed by #2933
Closed

Use mypy in boefjes, octopoes and rocky #2116

dekkers opened this issue Dec 11, 2023 · 0 comments · Fixed by #2933
Assignees
Labels
boefjes Issues related to boefjes octopoes Issues related to octopoes rocky Issues related to Rocky tech-debt

Comments

@dekkers
Copy link
Contributor

dekkers commented Dec 11, 2023

Currently mypy is excluded in boefjes, octopoes and rocky. We should also do type checking there because it can find bugs such as #2115. There are a lot of errors, but most look easy to fix. If some typing problems are hard to fix we can also use Any or ask mypy to ignore things because that would be better than not running mypy at all.

@dekkers dekkers added rocky Issues related to Rocky boefjes Issues related to boefjes octopoes Issues related to octopoes tech-debt labels Dec 11, 2023
@dekkers dekkers self-assigned this Feb 8, 2024
@dekkers dekkers added this to KAT Feb 8, 2024
@github-project-automation github-project-automation bot moved this to Incoming features / Need assessment in KAT Feb 8, 2024
@dekkers dekkers moved this from Incoming features / Need assessment to In Progress in KAT Feb 8, 2024
@ammar92 ammar92 moved this from In Progress to Ready for merge in KAT Feb 19, 2024
@underdarknl underdarknl moved this from Ready for merge to In Progress in KAT Feb 19, 2024
@dekkers dekkers moved this from In Progress to Review in KAT May 16, 2024
@ammar92 ammar92 moved this from Review to QA review / functional testing in KAT May 21, 2024
@stephanie0x00 stephanie0x00 moved this from QA review / functional testing to Ready for merge in KAT May 21, 2024
@github-project-automation github-project-automation bot moved this from Ready for merge to Done in KAT May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
boefjes Issues related to boefjes octopoes Issues related to octopoes rocky Issues related to Rocky tech-debt
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant