Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TypeScript: rendered markdown base uri should be relative to defining file #160018

Closed
DingWeizhe opened this issue Sep 4, 2022 · 3 comments
Closed

TypeScript: rendered markdown base uri should be relative to defining file #160018

DingWeizhe opened this issue Sep 4, 2022 · 3 comments
Assignees
@mjbvz
Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)

Comments

@DingWeizhe
Copy link
Contributor

DingWeizhe commented Sep 4, 2022 •
edited
Loading

Steps to Reproduce:

image

Completions:
image

Hover widget:
image

In the current B's link, the content in the markdown previewer will be <root_of_project>/b.ts
But it should be <root_of_project>/folder/b.ts(relative to folder/A.ts)
DingWeizhe pushed a commit to DingWeizhe/vscode that referenced this issue Sep 4, 2022
fix microsoft#160018
201178e
@DingWeizhe DingWeizhe mentioned this issue Sep 4, 2022
Closed
DingWeizhe pushed a commit to DingWeizhe/vscode that referenced this issue Sep 5, 2022
fix microsoft#160018
72cab0e
@DingWeizhe
Copy link
Contributor Author

relation issues: #86564

@mjbvz mjbvz added the typescript Typescript support issues label Sep 6, 2022
@mjbvz mjbvz changed the title markdown preview base uri is wrong TypeScript: rendered markdown base uri should be relative to defining file Sep 6, 2022
@mjbvz mjbvz added the bug Issue identified by VS Code Team member as probable bug label Sep 6, 2022
@DingWeizhe DingWeizhe mentioned this issue Sep 7, 2022
Closed
5 tasks
@DingWeizhe
Copy link
Contributor Author

I am creating a typescript issue for the response file path field when executing any command with documentation field.

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 15, 2022

Closing this in favor of the upstream issue: microsoft/TypeScript#47718

@mjbvz mjbvz closed this as completed Nov 15, 2022
@mjbvz mjbvz added the upstream Issue identified as 'upstream' component related (exists outside of VS Code) label Nov 15, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix #160018 - Markdown previewer with wrong baseUri DingWeizhe/vscode
2 participants
@DingWeizhe @mjbvz