Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

language service response documentation file path (QuickInfo、CompletionEntryDetails、SignatureHelp) #50665

Closed
5 tasks done
DingWeizhe opened this issue Sep 7, 2022 · 2 comments
Labels
Duplicate An existing issue was already created

Comments

@DingWeizhe
Copy link

Suggestion

in vscode IntelliSense will rendered markdown documents, but now the base URI is file being editing.
but should be relative to defining file.

So we need to add a file field to any response with documentation to render the markdown link / image correctly

vscode issues microsoft/vscode#160018

🔍 Search Terms

QuickInfo、CompletionEntryDetails、SignatureHelp

  • This wouldn't be a breaking change in existing TypeScript/JavaScript code
  • This wouldn't change the runtime behavior of existing JavaScript code
  • This could be implemented without emitting different JS based on the types of the expressions
  • This isn't a runtime feature (e.g. library functionality, non-ECMAScript syntax with JavaScript output, new syntax sugar for JS, etc.)
  • This feature would agree with the rest of TypeScript's Design Goals.

⭐ Suggestion

response documentation file path. when commands QuickInfo、CompletionEntryDetails、SignatureHelp.

📃 Motivating Example

💻 Use Cases

Improve vscode typescript documentation rendering correctness

@andrewbranch
Copy link
Member

Duplicate of #47718

@andrewbranch andrewbranch marked this as a duplicate of #47718 Sep 9, 2022
@andrewbranch andrewbranch added the Duplicate An existing issue was already created label Sep 9, 2022
@typescript-bot
Copy link
Collaborator

This issue has been marked as a 'Duplicate' and has seen no recent activity. It has been automatically closed for house-keeping purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

3 participants