fix(reload): do not throw when reload is racing with navigation #5113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
approved these changes
Jan 22, 2021
When `page.reload()` is racing against the renderer-initiated navigation, we might end up with `waitForNavigation()` being rejected before the reload implementation is able to catch it. To avoid that, carefully use Promise.all and await `waitForNavigation` from the get go. Same happens to `page.goForward()` and `page.goBack()`.
aslushnikov
pushed a commit
that referenced
this pull request
Jan 28, 2021
… (#5171) When `page.reload()` is racing against the renderer-initiated navigation, we might end up with `waitForNavigation()` being rejected before the reload implementation is able to catch it. To avoid that, carefully use Promise.all and await `waitForNavigation` from the get go. Same happens to `page.goForward()` and `page.goBack()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
page.reload()is racing against the renderer-initiatednavigation, we might end up with
waitForNavigation()being rejectedbefore the reload implementation is able to catch it.
To avoid that, carefully use Promise.all and await
waitForNavigationfrom the get go.
Same happens to
page.goForward()andpage.goBack().References #5111.