-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Frames crashes everything #5111
Comments
@shirshak55 Could you please answer some questions for us to better understand the issue?
|
Thanks. |
@shirshak55 Thanks, I can repro now. I'd like to better understand your scenario though. So, you are manually submitting a form and at the same time doing Now, what's happening. Playwright issues |
@dgozman Sometime we manually adjust filters in chat section (Like changing color, theme etc) (doing that from playwright is abit complicated as we are in testing phase) that reloads the page. But we monitor the chat for Machine learning purpose which needs reloading like 30 second. I think in any case browser/node process shouldn't stop. At least it should be caught by extension. May be if script is reloading the page it should stop manual reload and reload normally? I don't know whats the best way to solve this issue :) And the problem is not just manual imagine page refresh itself and playwright also tries to refresh it may crash right? Thank You 👍 |
I'd suggest you to just catch the reload in this case, because it seems totally fine in your usecase that reload does not work, and instead the form submit happens. Does that sound right? await page.reload().catch(console.log); However, this particular race scenario seems to be broken currently, and |
@dgozman that doesn't work. I have already done similar to this await page.reload().catch(e=>undefined) Yea I think this issue will be fixed if that race condition is fixed. |
|
Context
Version: ^1.8 (I have issue with above 1.7 too)
OS: Windows / MacOS (Not tested on LINUX)
Logs
And its always frames I don't know why. Its a normal code with page.goto.
Is there anyway at least just to ignore this error? Currently it stops whole node process and kills every contexts .
Global Error catcher are also not working:
I have even wrote following silly code:
But it still doesn't obey this and crashes everything.
When does it happens?
Thanks.
The text was updated successfully, but these errors were encountered: