Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(selectors): allow running selectors in the main world #1533

Merged
merged 1 commit into from
Mar 26, 2020
Merged

feat(selectors): allow running selectors in the main world #1533

merged 1 commit into from
Mar 26, 2020

Conversation

dgozman
Copy link
Contributor

@dgozman dgozman commented Mar 25, 2020 •
edited
Loading

Fixes #1316.

pavelfeldman
pavelfeldman requested changes Mar 25, 2020
View reviewed changes
Copy link
Member

@pavelfeldman pavelfeldman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you split it into preliminary moves and the actual changes? Otherwise, I don't think I can follow the changes!

docs/api.md Outdated Show resolved Hide resolved
@dgozman
Copy link
Contributor Author

dgozman commented Mar 25, 2020

Could you split it into preliminary moves and the actual changes? Otherwise, I don't think I can follow the changes!

Sure, please see #1536.

@dgozman dgozman changed the title feat(selectors): allow running selectors in main world feat(selectors): allow running selectors in the main world Mar 25, 2020
@dgozman
Copy link
Contributor Author

dgozman commented Mar 25, 2020

Please take another look.

@dgozman dgozman requested a review from pavelfeldman March 25, 2020 22:10
pavelfeldman
pavelfeldman approved these changes Mar 25, 2020
View reviewed changes
docs/api.md Outdated Show resolved Hide resolved
@dgozman dgozman merged commit bce8fc1 into microsoft:master Mar 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Allow custom selector engines to run in the main world
2 participants
@dgozman @pavelfeldman