Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Allow custom selector engines to run in the main world #1316

Closed
dgozman opened this issue Mar 10, 2020 · 0 comments · Fixed by #1533
Closed

[Feature] Allow custom selector engines to run in the main world #1316

dgozman opened this issue Mar 10, 2020 · 0 comments · Fixed by #1533
Assignees
@dgozman

Comments

@dgozman
Copy link
Contributor

dgozman commented Mar 10, 2020

No description provided.

@dgozman dgozman added the v1 label Mar 10, 2020
@dgozman dgozman self-assigned this Mar 10, 2020
@aslushnikov aslushnikov mentioned this issue Mar 10, 2020
Closed
This was referenced Mar 25, 2020
Merged
Merged
dgozman added a commit that referenced this issue Mar 25, 2020
@dgozman
chore(selectors): move selectors logic to selectors.ts (#1536)
60942d0 
This encapsulates selectors logic in one place, in a preparation for more complex scenarios like main-world selectors or piercing frames.

Note: we had `Page.fill should wait for visible visibilty` test, but we do not actually wait for visible in page.fill(). It happened to pass due to lucky evaluation order.

References #1316.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgozman dgozman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(selectors): allow running selectors in the main world
1 participant
@dgozman