Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] implement happy eyeballs for API testing #18790

Closed
yury-s opened this issue Nov 14, 2022 · 0 comments · Fixed by #19902
Closed

[Feature] implement happy eyeballs for API testing #18790

yury-s opened this issue Nov 14, 2022 · 0 comments · Fixed by #19902
Assignees
@yury-s
Labels
v1.30

Comments

@yury-s
Copy link
Member

yury-s commented Nov 14, 2022 •
edited
Loading

After switching from Node.js 16 to 18 API tests started failing in Java because it only binds ipv4 127.0.0.1 and node resolves localhost to ::1 by default. To mitigate that we'd like to implement happy eyeballs on our end before node itself fixes it (see nodejs/node#41625).
@yury-s yury-s added the v1.29 label Nov 14, 2022
@yury-s yury-s self-assigned this Nov 14, 2022
yury-s added a commit to yury-s/playwright that referenced this issue Nov 14, 2022
@yury-s
Revert "chore(driver): roll driver to recent Node.js LTS version (mic…
21f7801 
…rosoft#18636)"

The new node resolves loalhost to ::1 by default which breaks API tests
in the ports (Java in particular). Reverting to the previous LTS to allow
some time to implement happy eyeball algortithm on our end by next release.

This reverts commit 63a0b75.
Reference microsoft#18790
@yury-s yury-s mentioned this issue Nov 14, 2022
Merged
@yury-s yury-s changed the title [Feature] implement happy eyeball for API testing [Feature] implement happy eyeballs for API testing Nov 14, 2022
yury-s added a commit that referenced this issue Nov 14, 2022
@yury-s
Revert "chore(driver): roll driver to recent Node.js LTS version (#18… (
70065ba 
#18791)

…636)"

The new node resolves loalhost to ::1 by default which breaks API tests
in the ports (Java in particular). Reverting to the previous LTS to
allow some time to implement happy eyeballs algorithm on our end by next
release.

This reverts commit 63a0b75.
Reference #18790
yury-s added a commit to yury-s/playwright that referenced this issue Nov 14, 2022
@yury-s
cherry-pick(microsoft#18791): Revert "chore(driver): roll driver to r…
3e43c76 
…ecent Node.js LTS version (microsoft#18…

…636)"

The new node resolves loalhost to ::1 by default which breaks API tests
in the ports (Java in particular). Reverting to the previous LTS to
allow some time to implement happy eyeballs algorithm on our end by next
release.

This reverts commit 63a0b75.
Reference microsoft#18790
@yury-s yury-s mentioned this issue Nov 14, 2022
Merged
yury-s added a commit that referenced this issue Nov 14, 2022
@yury-s
cherry-pick(#18791): Revert "chore(driver): roll driver to recent Nod… (
db93e97 
#18794)

…e.js LTS version (#18636)"

The new node resolves loalhost to ::1 by default which breaks API tests
in the ports (Java in particular). Reverting to the previous LTS to
allow some time to implement happy eyeballs algorithm on our end by next
release.

This reverts commit 63a0b75. Reference
#18790
@aslushnikov aslushnikov added v1.30 and removed v1.29 labels Dec 15, 2022
@yury-s yury-s mentioned this issue Jan 5, 2023
Merged
yury-s added a commit that referenced this issue Jan 5, 2023
@yury-s
feat(fetch): happy eyeballs (#19902)
10ccfa9 
Fixes #18790
@mxschmitt mxschmitt mentioned this issue Jan 16, 2023
Closed
@mxschmitt mxschmitt mentioned this issue Jan 25, 2023
Merged
mxschmitt pushed a commit that referenced this issue Jan 25, 2023
@github-actions
chore(driver): roll driver to recent Node.js LTS version (#20319)
9f97190 
Since #18790 is merged and
got released in 1.30 we can merge this now.

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yury-s yury-s

Labels
v1.30
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(fetch): happy eyeballs yury-s/playwright
2 participants
@aslushnikov @yury-s