Disable absl symbolize in Windows Release build #21923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I examined the new binary. It no longer depends on dbghelp.dll. |
pranavsharma
approved these changes
Aug 30, 2024
snnn
added a commit
that referenced
this pull request
Aug 30, 2024
### Description This change disables Abseil's symbolize functionality in Windows non-debug builds. ### Motivation and Context To solve #21826. Avoid having a dependency on dbghelp.dll.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change disables Abseil's symbolize functionality in Windows non-debug builds.
Motivation and Context
To solve #21826. Avoid having a dependency on dbghelp.dll.
As I said in another PR, VC++ team's std::stacktrace implementation is more elegant than Abseil's. C++20's std::stacktrace can dynamically detect if the DLL exists or not, so it doesn't have a hard dependency on it.