Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release version of onnxruntime.dll has a dependency on dbghelp.dll #21826

Closed
ivanst0 opened this issue Aug 22, 2024 · 8 comments
Closed

Release version of onnxruntime.dll has a dependency on dbghelp.dll #21826

ivanst0 opened this issue Aug 22, 2024 · 8 comments
Assignees
@snnn
Labels
build build issues; typically submitted using template release:1.19.0 Cherry pick to ORT 1.19

Comments

@ivanst0
Copy link
Member

ivanst0 commented Aug 22, 2024

Describe the issue

Release version of onnxruntime.dll has a dependency on dbghelp.dll (using functions SymInitialize, SymFromAddr, SymSetOptions) while this functionality is not needed in a release build.
This is a regression, likely caused by #21300 (2024-07-10).

To reproduce

.\build.bat --config RelWithDebInfo --build_shared_lib

dumpbin /imports onnxruntime.dll

Urgency

No response

Platform

Windows

OS Version

Any

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

1.19

ONNX Runtime API

C++

Architecture

X64

Execution Provider

Default CPU

Execution Provider Library Version

No response
@carzh carzh added the build build issues; typically submitted using template label Aug 22, 2024
@carzh
Copy link
Contributor

carzh commented Aug 22, 2024

Thanks for flagging & spotting this -- is the unnecessary dependency causing any performance issues for you or larger package sizes?

@sophies927 sophies927 added the release:1.19.0 Cherry pick to ORT 1.19 label Aug 22, 2024
@ivanst0
Copy link
Member Author

ivanst0 commented Aug 23, 2024

One of our customers complains that they are not able to load our DLL while using LoadLibraryEx(..., LOAD_LIBRARY_SEARCH_DLL_LOAD_DIR) (our DLL has a dependency on onnxruntime.dll).

@carzh
Copy link
Contributor

carzh commented Aug 23, 2024

We are waiting on more task but this should be resolved early next week

@snnn
Copy link
Member

snnn commented Aug 27, 2024

I can confirm 1.18.1 release does not have the issue but the latest one(1.19.0) has it.

@snnn snnn self-assigned this Aug 27, 2024
@snnn
Copy link
Member

snnn commented Aug 29, 2024

The commit id 8749fa3 seems to be fine.

@snnn
Copy link
Member

snnn commented Aug 29, 2024

It is because PR #21410.

@snnn
Copy link
Member

snnn commented Aug 29, 2024

The dep is pulled by abseil's symbolize library.

@snnn
Copy link
Member

snnn commented Aug 29, 2024

Unfortunately, there is no formal way to disable it: abseil/abseil-cpp#1363

@snnn snnn mentioned this issue Aug 29, 2024
Merged
snnn added a commit that referenced this issue Aug 30, 2024
@snnn
Disable absl symbolize in Windows Release build (#21923)
1f879c3 
### Description
This change disables Abseil's symbolize functionality in Windows
non-debug builds.
### Motivation and Context
To solve #21826. Avoid having a dependency on dbghelp.dll.
snnn added a commit that referenced this issue Aug 30, 2024
@snnn
Disable absl symbolize in Windows Release build (#21923)
e2224c0 
### Description
This change disables Abseil's symbolize functionality in Windows
non-debug builds.
### Motivation and Context
To solve #21826. Avoid having a dependency on dbghelp.dll.
@snnn snnn closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snnn snnn

Labels
build build issues; typically submitted using template release:1.19.0 Cherry pick to ORT 1.19
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@snnn @ivanst0 @carzh @sophies927