Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revendor Microsoft/go-winio for 8gB file fix in wclayer #876

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

TBBle
Copy link
Contributor

@TBBle TBBle commented Sep 9, 2020

This pulls in the migration of go-winio/backuptar from the bundled fork of archive/tar from Go 1.6 to using Go's current archive/tar. See microsoft/go-winio#175

This resolves a problem creating OCI layers containing files larger than 8gB. See microsoft/Windows-Containers#43. Currently only affects the wclayer utility, as the only current user of the internal/ociwclayer package, which is the only code in this project using go-winio/backuptar.

This pulls in the migration of go-winio/backuptar from the bundled fork
of archive/tar from Go 1.6 to using Go's current archive/tar.

Currently only affects the wclayer utility, but resolves a problem
creating OCI layers containing files larger than 8gB.

Signed-off-by: Paul "TBBle" Hampson <[email protected]>
@TBBle TBBle requested a review from a team as a code owner September 9, 2020 12:37
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from reading the context but @ambarve for second set of eyes

Copy link
Member

@kevpar kevpar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevpar kevpar merged commit bfd1217 into microsoft:master Sep 23, 2020
@TBBle TBBle deleted the revendor-gowinio-for-updated-tar branch September 23, 2020 17:48
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
…ted-tar

Revendor Microsoft/go-winio for 8gB file fix in `wclayer`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants