Replace archive/tar fork with use of archive/tar #175
Conversation
Since Go 1.6, archive/tar has gained public support for custom PAX Records, so there's no need to maintain a fork of this library anymore. We do end up with a fork of the PAX timestamp parsing/formatting functions, but they are much less likely to change. Signed-off-by: Paul "TBBle" Hampson <[email protected]>
|
As it happens, this change will make it feasible to write sparse blocks to the stream in GNU tar PAX sparse format 1.0, which Edit: I just noticed that the OCI spec forbids sparse files anyway. |
|
It looks like this fix (or further hacks on the forked archive/tar) is needed to fix support for files larger than 8g when importing a layer, as we hit golang/go#15573. See microsoft/Windows-Containers#43 (comment) for reproduction case using hcsshim and moby/moby#40444 for a reproduction in Docker Desktop for Windows. |
|
Is there anything I can do to get this advanced, @ambarve, @kevpar? I know it says '37 files', but that's 34 deletions, one addition, and only two changed files, most of which was search-and-replace. I'd really like to land this, so we can start vendoring it into downstream users and resolve some of the referenced issues. |
|
LGTM! |
Since Go 1.6, archive/tar has gained public support for custom PAX Records, so there's no need to maintain a fork of this library anymore.
We do end up with a fork of the PAX timestamp parsing/formatting functions, but they are much less likely to change.
Copying the PAX time-parsing/formatting headers, and use of modTime as a fallback for creationTime inspired by containerd's reimplementation of this functionality, but recreated by hand.