Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add explicit children prop to TeachingBubble to support React 18 #24823

Merged
merged 3 commits into from
Sep 16, 2022
Merged

fix: Add explicit children prop to TeachingBubble to support React 18 #24823

merged 3 commits into from
Sep 16, 2022

Conversation

micahgodbolt
Copy link
Member

In React 18 we need to explicitly define if a component accepts children.

#22592

@micahgodbolt micahgodbolt requested review from a team as code owners September 15, 2022 20:27
@github-actions github-actions bot added this to the July Project Cycle Q3 2022 milestone Sep 15, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Sep 15, 2022 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 9077e0a7d3911096a3337d76ec65591d191a780a

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 15, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9d57533:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 15, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 918 923 5000
Breadcrumb mount 2891 2904 1000
Checkbox mount 2653 2635 5000
CheckboxBase mount 2391 2312 5000
ChoiceGroup mount 4695 4785 5000
ComboBox mount 979 970 1000
CommandBar mount 10918 10967 1000
ContextualMenu mount 12545 12571 1000
DefaultButton mount 1155 1197 5000
DetailsRow mount 3863 3819 5000
DetailsRowFast mount 3822 3755 5000
DetailsRowNoStyles mount 3662 3724 5000
Dialog mount 3124 3114 1000
DocumentCardTitle mount 182 187 1000
Dropdown mount 3407 3423 5000
FocusTrapZone mount 1905 1871 5000
FocusZone mount 1858 1846 5000
IconButton mount 1744 1812 5000
Label mount 361 380 5000
Layer mount 4680 4494 5000
Link mount 489 484 5000
MenuButton mount 1473 1489 5000
MessageBar mount 2214 2291 5000
Nav mount 3416 3379 1000
OverflowSet mount 1107 1105 5000
Panel mount 2543 2550 1000
Persona mount 1041 1016 1000
Pivot mount 1460 1441 1000
PrimaryButton mount 1333 1292 5000
Rating mount 7714 7720 5000
SearchBox mount 1294 1289 5000
Shimmer mount 2876 2923 5000
Slider mount 1997 2048 5000
SpinButton mount 5084 5125 5000
Spinner mount 439 458 5000
SplitButton mount 3252 3229 5000
Stack mount 505 517 5000
StackWithIntrinsicChildren mount 2357 2329 5000
StackWithTextChildren mount 5285 5210 5000
SwatchColorPicker mount 11896 11996 5000
TagPicker mount 2665 2784 5000
TeachingBubble mount 99213 98020 5000
Text mount 453 467 5000
TextField mount 1410 1444 5000
ThemeProvider mount 1361 1322 5000
ThemeProvider virtual-rerender 811 777 5000
ThemeProvider virtual-rerender-with-unmount 2072 2090 5000
Toggle mount 858 802 5000
buttonNative mount 131 144 5000

@size-auditor
Copy link

size-auditor bot commented Sep 15, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 9077e0a7d3911096a3337d76ec65591d191a780a (build)

@micahgodbolt micahgodbolt merged commit be154fe into microsoft:master Sep 16, 2022
@micahgodbolt micahgodbolt deleted the teaching-bubble-children branch September 16, 2022 15:35
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 19, 2022
@marcosmoura
Merge branch 'master' into marcosmoura/fix/card-codesandbox-examples
3db2b04 
* master: (28 commits)
  fix: use trigger prop for aria-haspopup (microsoft#24794)
  chore(react-dialog): scaffold DialogContent component (microsoft#24844)
  chore: Northstar screener should read from screenerStates.json (microsoft#24848)
  applying package updates
  (web components) Standardize focus treatment (microsoft#24771)
  Divider - allow default prop override (microsoft#24840)
  GroupedList: fix virtualization (unstable preview) (microsoft#24460)
  fix: Add explicit children prop to TeachingBubble to support React 18 (microsoft#24823)
  feat: Adds `visible` prop to `TableCellActions` (microsoft#24831)
  [Northstar][Dropdown] Fix styling mutation when merging themes (microsoft#24787)
  fix: export `tableCellActionsClassNames` from unstable (microsoft#24830)
  bugfix(react-dialog): Adds color style to DialogSurface (microsoft#24832)
  applying package updates
  Prevent group toggling from selecting the whole group (microsoft#24822)
  feat(react-textarea): Add shadow variant of filled appearance (microsoft#24512)
  applying package updates
  Adding lib-commonjs top-level entries to exports map (microsoft#24792)
  Created shim packages (microsoft#24780)
  feat(react-menu): replace keydown handlers by useARIAButtonShorthand on MenuItem (microsoft#24738)
  fix: update version mismatches triggered by v9 release (microsoft#24812)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TristanWatanabe TristanWatanabe TristanWatanabe approved these changes

@khmakoto khmakoto khmakoto approved these changes

Assignees

@Hotell Hotell

Labels
Component: TeachingBubble PR: API Modified
Projects
None yet
Milestone
July Project Cycle Q3 2022
Development

Successfully merging this pull request may close these issues.
6 participants
@micahgodbolt @fabricteam @khmakoto @TristanWatanabe @Hotell @msft-fluent-ui-bot