Prevent group toggling from selecting the whole group #24822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasMichon
changed the title
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6074ce9:
|
Asset size changes
Baseline commit: 151520d8a82767f0270793ce040c5aa6eefa64c0 (build) |
📊 Bundle size report🤖 This report was generated against 151520d8a82767f0270793ce040c5aa6eefa64c0 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 948 | 947 | 5000 | |
| Breadcrumb | mount | 3044 | 2917 | 1000 | |
| Checkbox | mount | 2740 | 2717 | 5000 | |
| CheckboxBase | mount | 2344 | 2230 | 5000 | |
| ChoiceGroup | mount | 4745 | 4835 | 5000 | |
| ComboBox | mount | 1124 | 1022 | 1000 | |
| CommandBar | mount | 10887 | 11354 | 1000 | |
| ContextualMenu | mount | 13294 | 12983 | 1000 | |
| DefaultButton | mount | 1206 | 1163 | 5000 | |
| DetailsRow | mount | 3782 | 3770 | 5000 | |
| DetailsRowFast | mount | 3920 | 3979 | 5000 | |
| DetailsRowNoStyles | mount | 3720 | 3678 | 5000 | |
| Dialog | mount | 3105 | 3192 | 1000 | |
| DocumentCardTitle | mount | 190 | 176 | 1000 | |
| Dropdown | mount | 3490 | 3443 | 5000 | |
| FocusTrapZone | mount | 1920 | 1889 | 5000 | |
| FocusZone | mount | 1821 | 1802 | 5000 | |
| IconButton | mount | 1769 | 1795 | 5000 | |
| Label | mount | 358 | 377 | 5000 | |
| Layer | mount | 4592 | 4695 | 5000 | |
| Link | mount | 464 | 477 | 5000 | |
| MenuButton | mount | 1562 | 1516 | 5000 | |
| MessageBar | mount | 2209 | 2388 | 5000 | |
| Nav | mount | 3418 | 3394 | 1000 | |
| OverflowSet | mount | 1067 | 1112 | 5000 | |
| Panel | mount | 2561 | 2574 | 1000 | |
| Persona | mount | 1052 | 990 | 1000 | |
| Pivot | mount | 1505 | 1451 | 1000 | |
| PrimaryButton | mount | 1297 | 1313 | 5000 | |
| Rating | mount | 8006 | 7879 | 5000 | |
| SearchBox | mount | 1283 | 1329 | 5000 | |
| Shimmer | mount | 2971 | 2940 | 5000 | |
| Slider | mount | 1981 | 1993 | 5000 | |
| SpinButton | mount | 5042 | 5027 | 5000 | |
| Spinner | mount | 431 | 432 | 5000 | |
| SplitButton | mount | 3271 | 3247 | 5000 | |
| Stack | mount | 527 | 503 | 5000 | |
| StackWithIntrinsicChildren | mount | 2313 | 2389 | 5000 | |
| StackWithTextChildren | mount | 5409 | 5353 | 5000 | |
| SwatchColorPicker | mount | 12104 | 12998 | 5000 | |
| TagPicker | mount | 2650 | 2708 | 5000 | |
| TeachingBubble | mount | 103427 | 103604 | 5000 | |
| Text | mount | 446 | 424 | 5000 | |
| TextField | mount | 1391 | 1428 | 5000 | |
| ThemeProvider | mount | 1344 | 1341 | 5000 | |
| ThemeProvider | virtual-rerender | 789 | 806 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2109 | 2100 | 5000 | |
| Toggle | mount | 851 | 834 | 5000 | |
| buttonNative | mount | 144 | 137 | 5000 |
spmonahan
approved these changes
Sep 15, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 19, 2022
* master: (28 commits) fix: use trigger prop for aria-haspopup (microsoft#24794) chore(react-dialog): scaffold DialogContent component (microsoft#24844) chore: Northstar screener should read from screenerStates.json (microsoft#24848) applying package updates (web components) Standardize focus treatment (microsoft#24771) Divider - allow default prop override (microsoft#24840) GroupedList: fix virtualization (unstable preview) (microsoft#24460) fix: Add explicit children prop to TeachingBubble to support React 18 (microsoft#24823) feat: Adds `visible` prop to `TableCellActions` (microsoft#24831) [Northstar][Dropdown] Fix styling mutation when merging themes (microsoft#24787) fix: export `tableCellActionsClassNames` from unstable (microsoft#24830) bugfix(react-dialog): Adds color style to DialogSurface (microsoft#24832) applying package updates Prevent group toggling from selecting the whole group (microsoft#24822) feat(react-textarea): Add shadow variant of filled appearance (microsoft#24512) applying package updates Adding lib-commonjs top-level entries to exports map (microsoft#24792) Created shim packages (microsoft#24780) feat(react-menu): replace keydown handlers by useARIAButtonShorthand on MenuItem (microsoft#24738) fix: update version mismatches triggered by v9 release (microsoft#24812) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Since the most-recent changes to improve group selection have gone in, there is a bug where clicking the button to toggle group state is propagating to select the whole group.
New Behavior
This PR prevents a click on the toggle button from propagating to select the whole group.