Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the router to use peerDependency for fast-element #7053

Merged
merged 2 commits into from
Dec 11, 2024

Conversation

janechu
Copy link
Collaborator

@janechu janechu commented Dec 11, 2024

Pull Request

📖 Description

The @microsoft/fast-router is erroneously using @microsoft/fast-element as a direct dependency, this is causing issues during publishing and is the incorrect dependency structure for the package.

✅ Checklist

General

  • I have included a change request file using $ npm run change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

@janechu janechu merged commit 1238af4 into master Dec 11, 2024
5 checks passed
@janechu janechu deleted the users/janechu/change-fast-router-to-use-peerdeps branch December 11, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant