Skip to content

Commit

Permalink
Change the router to use peerDependency for fast-element (#7053)
Browse files Browse the repository at this point in the history
# Pull Request

## 📖 Description

The `@microsoft/fast-router` is erroneously using `@microsoft/fast-element` as a direct dependency, this is causing issues during publishing and is the incorrect dependency structure for the package.

## ✅ Checklist

### General

<!--- Review the list and put an x in the boxes that apply. -->

- [ ] I have included a change request file using `$ npm run change`
- [ ] I have added tests for my changes.
- [ ] I have tested my changes.
- [ ] I have updated the project documentation to reflect my changes.
- [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](https://github.com/microsoft/fast/blob/master/CODE_OF_CONDUCT.md#our-standards) for this project.
  • Loading branch information
janechu authored Dec 11, 2024
1 parent 7967174 commit 1238af4
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "prerelease",
"comment": "Change the router to use peerDependency for fast-element",
"packageName": "@microsoft/fast-router",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 4 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion packages/web-components/fast-router/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@
"devDependencies": {
"@jsdevtools/coverage-istanbul-loader": "^3.0.5",
"@microsoft/api-extractor": "^7.47.0",
"@microsoft/fast-element": "^2.0.0",
"@types/chai": "^4.2.11",
"@types/karma": "^6.3.3",
"@types/mocha": "^7.0.2",
Expand Down Expand Up @@ -80,7 +81,7 @@
"webpack": "^5.92.1",
"webpack-cli": "^5.1.4"
},
"dependencies": {
"peerDependencies": {
"@microsoft/fast-element": "^2.0.0"
},
"beachball": {
Expand Down

0 comments on commit 1238af4

Please sign in to comment.