Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking β€œSign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tabbable shadow dom support #5606

Closed
wants to merge 11 commits into from
Closed
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
working
Stephane Comeau committed May 5, 2022
commit 758299f57427eae2dfa150551f0b181b2b2c4d1e
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { attr, DOM, Notifier, Observable } from "@microsoft/fast-element";
import { keyEscape, keyTab } from "@microsoft/fast-web-utilities";
import { isTabbable } from "tabbable";
import { FoundationElement } from "../foundation-element/foundation-element.js";
import { isTabbable, tabbable } from "tabbable";
import { FoundationElement } from "../foundation-element";

/**
* A Switch Custom HTML Element.
@@ -219,9 +219,9 @@ export class Dialog extends FoundationElement {
};

private getTabQueueBounds = (): (HTMLElement | SVGElement)[] => {
const bounds: HTMLElement[] = [];
// const bounds: HTMLElement[] = [];

return Dialog.reduceTabbableItems(bounds, this);
return tabbable(this);
};

/**
5 changes: 5 additions & 0 deletions yarn.lock
Original file line number Diff line number Diff line change
@@ -23160,6 +23160,11 @@ symbol.prototype.description@^1.0.0:
has-symbols "^1.0.2"
object.getownpropertydescriptors "^2.1.2"

[email protected]:
version "5.3.0-beta.0"
resolved "https://registry.yarnpkg.com/tabbable/-/tabbable-5.3.0-beta.0.tgz#2840539883f236f2887312431fbfe07dc305bce5"
integrity sha512-zNNUKn79Qve4JNB3/tP38EdS8eA4Phjh6go1TQ1/o2QcQDoTBVbS4hDYwj6jF4242fCMseo1fLBfaeAQqVgOcA==

tabbable@^4.0.0:
version "4.0.0"
resolved "https://registry.yarnpkg.com/tabbable/-/tabbable-4.0.0.tgz#5bff1d1135df1482cf0f0206434f15eadbeb9261"