-
Notifications
You must be signed in to change notification settings - Fork 601
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use tabbable shadow dom support #5606
Conversation
c1fcd7c
to
bf1debe
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
FYI, tabbable v5.3.0 and focus-trap v6.8.0 with Shadow DOM support have been published to NPM. I hope it helps for this! |
@scomea let's get this up to date, I'd like to see if we can get this in for the final versions of fast-components. |
bf1debe
to
29b4f67
Compare
Due to draft status, conflicts, and potential issues with this PR being fairly out of date we're closing as part of #6951. |
π Description
This pr updates the dialog and toolbar elements to use tabbable's new shadom dom support.
π« Issues
Removes some local code.
π©βπ» Reviewer Notes
π Test Plan
β Checklist
General
$ yarn change
Component-specific