Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use tabbable shadow dom support #5606

Closed
wants to merge 11 commits into from
Closed

Conversation

scomea
Copy link
Collaborator

@scomea scomea commented Feb 16, 2022

πŸ“– Description

This pr updates the dialog and toolbar elements to use tabbable's new shadom dom support.

🎫 Issues

Removes some local code.

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

  • todo: add some shadow dom tests for dialog/toolbar, ideally in play wright.

βœ… Checklist

General

  • I have included a change request file using $ yarn change
  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

@scomea scomea force-pushed the users/scomea/tabbabletest branch from c1fcd7c to bf1debe Compare March 8, 2022 17:25
@stale
Copy link

stale bot commented Apr 16, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the warning:stale No recent activity within a reasonable amount of time label Apr 16, 2022
@stefcameron
Copy link

FYI, tabbable v5.3.0 and focus-trap v6.8.0 with Shadow DOM support have been published to NPM. I hope it helps for this!

@stale stale bot removed the warning:stale No recent activity within a reasonable amount of time label Apr 20, 2022
@chrisdholt
Copy link
Member

@scomea let's get this up to date, I'd like to see if we can get this in for the final versions of fast-components.

@chrisdholt chrisdholt added the fast-components:final Issues or PR's to include in the final release of fast-components label Apr 27, 2022
@chrisdholt chrisdholt removed the fast-components:final Issues or PR's to include in the final release of fast-components label May 5, 2022
@scomea scomea force-pushed the users/scomea/tabbabletest branch from bf1debe to 29b4f67 Compare May 5, 2022 19:07
Stephane Comeau added 2 commits May 5, 2022 14:54
@janechu
Copy link
Collaborator

janechu commented Jun 14, 2024

Due to draft status, conflicts, and potential issues with this PR being fairly out of date we're closing as part of #6951.

@janechu janechu closed this Jun 14, 2024
@janechu janechu deleted the users/scomea/tabbabletest branch June 14, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants