RFC: Removal of @microsoft/eslint-config-fast-dna
#6948
Milestone
Comments
janechu
added a commit
that referenced
this issue
May 24, 2024
# Pull Request ## 📖 Description Removal of the `@microsoft/eslint-config-fast-dna` package as we reserve the right to change eslint configurations and will not be maintaining a package outside this repository. As such, the configuration options have been moved to the root `.eslintrc`. ### 🎫 Issues Resolves #6948 ## 👩💻 Reviewer Notes The logic has not changed here, we are only moving this package configuration options internal, and I have added "prettier" as an extension as all current packages re-extend it anyway. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project.
github-project-automation
bot
moved this from Triage
to Done
in FAST Architecture Roadmap
janechu
added a commit
that referenced
this issue
Jun 10, 2024
# Pull Request ## 📖 Description Removal of the `@microsoft/eslint-config-fast-dna` package as we reserve the right to change eslint configurations and will not be maintaining a package outside this repository. As such, the configuration options have been moved to the root `.eslintrc`. ### 🎫 Issues Resolves #6948 ## 👩💻 Reviewer Notes The logic has not changed here, we are only moving this package configuration options internal, and I have added "prettier" as an extension as all current packages re-extend it anyway. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Removal of
@microsoft/eslint-config-fast-dnaReason for removal
The eslint rules package is not something we would recommend others take a dependency on and we are actively re-evaluating the current ruleset.
The text was updated successfully, but these errors were encountered: