-
Notifications
You must be signed in to change notification settings - Fork 601
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Remove eslint config package (#6970)
# Pull Request ## 📖 Description Removal of the `@microsoft/eslint-config-fast-dna` package as we reserve the right to change eslint configurations and will not be maintaining a package outside this repository. As such, the configuration options have been moved to the root `.eslintrc`. ### 🎫 Issues Resolves #6948 ## 👩💻 Reviewer Notes The logic has not changed here, we are only moving this package configuration options internal, and I have added "prettier" as an extension as all current packages re-extend it anyway. ## ✅ Checklist ### General <!--- Review the list and put an x in the boxes that apply. --> - [x] I have included a change request file using `$ yarn change` - [ ] I have added tests for my changes. - [x] I have tested my changes. - [ ] I have updated the project documentation to reflect my changes. - [x] I have read the [CONTRIBUTING](https://github.com/microsoft/fast/blob/master/CONTRIBUTING.md) documentation and followed the [standards](/docs/community/code-of-conduct/#our-standards) for this project.
- Loading branch information
Showing
61 changed files
with
254 additions
and
322 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,85 @@ | ||
module.exports = { | ||
extends: ["@microsoft/eslint-config-fast-dna", "prettier"], | ||
root: true, | ||
parser: "@typescript-eslint/parser", | ||
plugins: ["@typescript-eslint", "import"], | ||
extends: [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/eslint-recommended", | ||
"plugin:@typescript-eslint/recommended", | ||
"prettier" | ||
], | ||
rules: { | ||
"no-unused-vars": "off", | ||
"no-extra-boolean-cast": "off", | ||
"no-empty-function": "off", | ||
"@typescript-eslint/no-empty-function": [ | ||
"error", | ||
{ allow: ["asyncMethods", "methods"] }, | ||
], | ||
"@typescript-eslint/no-use-before-define": "off", | ||
"@typescript-eslint/typedef": "off", | ||
"@typescript-eslint/explicit-function-return-type": "off", | ||
"max-len": ["error", 140], | ||
"import/order": "error", | ||
"sort-imports": [ | ||
"error", | ||
{ | ||
ignoreCase: true, | ||
ignoreDeclarationSort: true, | ||
}, | ||
], | ||
"comma-dangle": "off", | ||
"@typescript-eslint/no-empty-interface": [ | ||
"error", | ||
{ | ||
allowSingleExtends: true, | ||
}, | ||
], | ||
"@typescript-eslint/camelcase": "off", | ||
"@typescript-eslint/naming-convention": [ | ||
"error", | ||
{ | ||
selector: "default", | ||
format: ["UPPER_CASE", "camelCase", "PascalCase"], | ||
leadingUnderscore: "allow", | ||
}, | ||
{ | ||
selector: "property", | ||
format: null, // disable for property names because of our foo__expanded convention for JSS | ||
// TODO: I think we can come up with a regex that ignores variables with __ in them | ||
}, | ||
{ | ||
selector: "variable", | ||
format: null, // disable for variable names because of our foo__expanded convention for JSS | ||
// TODO: I think we can come up with a regex that ignores variables with __ in them | ||
}, | ||
{ | ||
selector: "interface", | ||
format: ["PascalCase"], | ||
custom: { | ||
regex: "^I[A-Z]", | ||
match: false, | ||
}, | ||
}, | ||
], | ||
"@typescript-eslint/no-inferrable-types": "off", | ||
"no-prototype-builtins": "off", | ||
"no-fallthrough": "off", | ||
"no-unexpected-multiline": "off", | ||
"@typescript-eslint/no-unused-vars": ["warn", { args: "none" }], | ||
"@typescript-eslint/no-explicit-any": "off", | ||
}, | ||
overrides: [ | ||
{ | ||
files: ["**/*.js"], | ||
extends: ["eslint:recommended"], | ||
env: { | ||
node: true, | ||
"shared-node-browser": true, | ||
}, | ||
rules: { | ||
"@typescript-eslint/no-var-requires": "off", | ||
}, | ||
}, | ||
], | ||
}; |
Validating CODEOWNERS rules …
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-element-ef223a56-58c8-4bb4-bfe5-7a8064470cac.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "Remove eslint config package", | ||
"packageName": "@microsoft/fast-element", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-foundation-b755c2d8-0a57-4ac0-8ca5-837c2b703606.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "Remove eslint config package", | ||
"packageName": "@microsoft/fast-foundation", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-router-80550cb4-2f40-48d3-ab8a-cff698557c14.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "Remove eslint config package", | ||
"packageName": "@microsoft/fast-router", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-ssr-b91534b8-d9b9-496e-be43-f3020e919985.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "Remove eslint config package", | ||
"packageName": "@microsoft/fast-ssr", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
7 changes: 7 additions & 0 deletions
7
change/@microsoft-fast-web-utilities-8ffff82d-8671-40ce-938f-86f88fccc4de.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"type": "none", | ||
"comment": "Remove eslint config package", | ||
"packageName": "@microsoft/fast-web-utilities", | ||
"email": "[email protected]", | ||
"dependentChangeType": "none" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.