Change XmlnsPrefix casing to lowercase. #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Fix] Name 'Interactions' does not match rule 'Namespace alias'. Suggested name is 'interactions'
|
This is a breaking change that has not been discussed as an issue. Please submit an issue to discuss this request first. |
|
@brianlagunas I don't think this would have been a breaking change. The XmlnsPrefixAttribute is simply a hint to the IDE for what xmlns prefix to generate when a type from this assembly gets added to the XAML file and no appropriate xmlns exists yet. But if @xxMUROxx creates an issue we can have that discussion there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Suggest to Change the XmlnsPrefix from Interactions to interactions since other libraries uses lower case to and ReSharper suggests me to change the casing to lowercase.