Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to change XmlnsPrefix casing to lowercase. #29

Closed
michaelmairegger opened this issue Jan 4, 2019 · 6 comments
Closed

Suggest to change XmlnsPrefix casing to lowercase. #29

michaelmairegger opened this issue Jan 4, 2019 · 6 comments

Comments

@michaelmairegger
Copy link
Contributor

I suggest to change the XmlnsPrefix from Interactions to interactions since other libraries uses lower case to and ReSharper suggests me to change the casing to lowercase.

Name 'Interactions' does not match rule 'Namespace alias'. Suggested name is 'interactions'.

PR referenced: #28

@pedrolamas
Copy link
Collaborator

Seems reasonable to me, not exactly a breaking change as this would just affect new pages created, not existing ones!

@brianlagunas
Copy link
Collaborator

I would actually prefer to see a shorter prefix such as just i instead of a full interactions.

Actually, I think it's strange that a Microsoft.Xaml.Behaviors namespace maps to an interactions prefix. Doesn't it make more sense to map to a behaviors prefix or simply a b?

@mgoertz-msft
Copy link
Member

One of the criticisms of XAML is that it's too verbose, so I'm fine with just b.

@michaelmairegger
Copy link
Contributor Author

I like Shorter prefixes too, should i change the PR to that one so that the cange can, later, be merged?

@pedrolamas
Copy link
Collaborator

You have 3x "ok" here, I think it's safe to go ahead with this change.

@brianlagunas
Copy link
Collaborator

I also would prefer to change this to just b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants