Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRTK3 Example Scene Polish #11744

Merged

Conversation

AMollis
Copy link
Member

@AMollis AMollis commented Jul 27, 2023

Overview

This change polishes the existing MRTK3 example scenes. Things fixed

  • Where possible, the scene's description panel was updated to include an "Object Manipulator" so the scene content can be moved
  • The 'Simple Profiler' added to every scene
  • Hand Rays disabled by default in eye-gaze interaction scene
  • Updated 'Example Hand Menu' to initialize its state based on interactors' enablement at start time.
  • The dictation example now re-enables keyword recognition once dictation stops.
  • Improved 'Solver Example' scene layout
  • Improved 'Speech Input Example' scene layout, and change 'global speech' sample to change shape/mesh of the game objects to better demonstrate using stateful interactor's keyword feature.
  • Improved 'Dwell Example' scene layout
  • Improved all eye gaze scene layouts
  • Improved 'Disable Interactor Example' scene layout
  • Improved 'Virtualized Scroll Rect List' scene layout, and added touch scrolling to the list
  • Improved 'Scrolling Example' scene layout, and improved its performance by reducing game objects
  • Updated 'Disable Interactor Example' so it's harder to get stuck.
  • Fixed 'Eye Tracking Visualizer Example' scene so eye tracking recording works on device
  • Fixing text example scene to use TextMeshPro

Changes

Verification

This optional section is a place where you can detail the specific type of verification
you want from reviewers. For example, if you want reviewers to checkout the PR locally
and validate the functionality of specific scenarios, provide instructions
on the specific scenarios and what you want verified.

If there are specific areas of concern or question feel free to highlight them here so
that reviewers can watch out for those issues.

As a reviewer, it is possible to check out this change locally by using the following
commands (substituting {PR_ID} with the ID of this pull request):

git fetch origin pull/{PR_ID}/head:name_of_local_branch

git checkout name_of_local_branch

AMollis added 5 commits July 22, 2023 00:26
…ene, adding profiler to scenes, polishing some UI, fixing dictation sample bug, hiding hand rays by default in eye tracking samples
@AMollis AMollis enabled auto-merge (squash) July 27, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants