Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRTK3 DictionExample doesn't re-enable keyword recognition after dictation is enabled and disabled again #11725

Closed
AMollis opened this issue Jul 22, 2023 · 1 comment
Closed

MRTK3 DictionExample doesn't re-enable keyword recognition after dictation is enabled and disabled again #11725

AMollis opened this issue Jul 22, 2023 · 1 comment
Assignees
@AMollis
Labels
Bug IssueMigrated MRTK3
Milestone
MRTK v3.0 GA

Comments

@AMollis
Copy link
Member

AMollis commented Jul 22, 2023 •
edited by IssueSyncBot
Loading

This issue has been migrated a new MRTK repository, and the status of this issue will now be tracked at the following location:

Describe the bug

MRTK3 DictionExample doesn't re-enable keyword recognition after dictation is enabled

To reproduce

Steps to reproduce the behavior:

  1. Go to MRTK3's DictionExample
  2. Stare at "Start Dictation" button and say "Select"
  3. Dictation service should start
  4. Click "Stop Dictation" button
  5. Stare at "Start Dictation" button and say "Select"
  6. Dictation service does not start (BUG)

Expected behavior

Dictation service should start.
@AMollis AMollis added the Bug label Jul 22, 2023
@AMollis AMollis added this to the MRTK v3.0 GA milestone Jul 22, 2023
@github-actions github-actions bot added the MRTK3 label Jul 22, 2023
@AMollis AMollis changed the title MRTK3 DictionExample doesn't re-enable keyword recognition after dictation is enabled MRTK3 DictionExample doesn't re-enable keyword recognition after dictation is enabled and disabled again Jul 22, 2023
@AMollis AMollis assigned AMollis and unassigned marlenaklein-msft Jul 24, 2023
@AMollis AMollis mentioned this issue Jul 27, 2023
Merged
AMollis added a commit that referenced this issue Jul 27, 2023
@AMollis
MRTK3 Example Scene Polish (#11744)
b30acdb 
## Overview
This change polishes the existing MRTK3 example scenes.  Things fixed

- Where possible, the scene's description panel was updated to include an "Object Manipulator" so the scene content can be moved
- The 'Simple Profiler' added to every scene
- Hand Rays disabled by default in eye-gaze interaction scene
- Updated 'Example Hand Menu' to initialize its state based on interactors' enablement at start time.
- The dictation example now re-enables keyword recognition once dictation stops.
- Improved 'Solver Example' scene layout
- Improved 'Speech Input Example' scene layout, and change 'global speech' sample to change shape/mesh of the game objects to better demonstrate using stateful interactor's keyword feature.
- Improved 'Dwell Example' scene layout
- Improved all eye gaze scene layouts
- Improved 'Disable Interactor Example' scene layout
- Improved 'Virtualized Scroll Rect List' scene layout, and added touch scrolling to the list
- Improved 'Scrolling Example' scene layout, and improved its performance by reducing game objects
- Updated 'Disable Interactor Example' so it's harder to get stuck.
- Fixed 'Eye Tracking Visualizer Example' scene so eye tracking recording works on device
- Fixing text example scene to use TextMeshPro


## Changes
- Fixes: #11731
- Fixes: #11730
- Fixes: #11726
- Fixes: #11725
@AMollis
Copy link
Member Author

AMollis commented Jul 27, 2023

Fixed with

@AMollis AMollis closed this as completed Jul 27, 2023
@IssueSyncBot IssueSyncBot mentioned this issue Aug 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AMollis AMollis

Labels
Bug IssueMigrated MRTK3
Projects
None yet
Milestone
MRTK v3.0 GA
Development

No branches or pull requests
3 participants
@AMollis @marlenaklein-msft @IssueSyncBot