Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more cpp lints #2985

Merged
merged 3 commits into from
Apr 13, 2020
Merged

more cpp lints #2985

merged 3 commits into from
Apr 13, 2020

Conversation

guolinke
Copy link
Collaborator

@guolinke guolinke commented Apr 9, 2020

refer to #1990

@guolinke guolinke requested a review from chivee as a code owner April 9, 2020 13:35
@guolinke guolinke requested a review from StrikerRUS April 9, 2020 13:35
@@ -313,6 +313,7 @@ inline static unsigned CountDecimalDigit32(uint32_t n) {
1000000000
};
#ifdef _MSC_VER
// NOLINT
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

_BitScanReverse only accepts unsigned long.

@StrikerRUS
Copy link
Collaborator

I guess NOLINT should be on the same line.

False positives can be ignored by putting // NOLINT at the end of the line or // NOLINTNEXTLINE in the previous line.
https://google.github.io/styleguide/cppguide.html#cpplint

@StrikerRUS
Copy link
Collaborator

@jameslamb
We have a new NOTE here on macOS

* checking examples ... NOTE
Examples with CPU or elapsed time > 5s
     user system elapsed
dim 5.426  0.264    5.79

Can you please take a look?

@jameslamb
Copy link
Collaborator

@jameslamb
We have a new NOTE here on macOS

* checking examples ... NOTE
Examples with CPU or elapsed time > 5s
     user system elapsed
dim 5.426  0.264    5.79

Can you please take a look?

😬 wow looks like we have been just barely getting under some of these checks.

I'll take a look. Opened #2988 , should be quick to fix

@jameslamb
Copy link
Collaborator

@jameslamb
We have a new NOTE here on macOS

* checking examples ... NOTE
Examples with CPU or elapsed time > 5s
     user system elapsed
dim 5.426  0.264    5.79

Can you please take a look?

😬 wow looks like we have been just barely getting under some of these checks.

I'll take a look. Opened #2988 , should be quick to fix

created #2989 to fix it

Copy link
Collaborator

@StrikerRUS StrikerRUS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 cpplint issue left, awesome! 🎉

@jameslamb jameslamb merged commit 5c0baf6 into master Apr 13, 2020
@StrikerRUS StrikerRUS deleted the guoke-cpp-lint branch April 13, 2020 22:20
@lock lock bot locked as resolved and limited conversation to collaborators Jun 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants