-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
more cpp lints #2985
more cpp lints #2985
Conversation
include/LightGBM/utils/common.h
Outdated
@@ -313,6 +313,7 @@ inline static unsigned CountDecimalDigit32(uint32_t n) { | |||
1000000000 | |||
}; | |||
#ifdef _MSC_VER | |||
// NOLINT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_BitScanReverse
only accepts unsigned long
.
I guess
|
@jameslamb
Can you please take a look? |
😬 wow looks like we have been just barely getting under some of these checks. I'll take a look. Opened #2988 , should be quick to fix |
created #2989 to fix it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 cpplint issue left, awesome! 🎉
refer to #1990