-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix cpp lint problems #1990
Comments
Total errors found: 674 Report (Clickable):
|
@guolinke Can we have for |
Total errors found: 752 Report (Clickable):
|
@guolinke WDYT about copyright message? |
for the copyright, I think it is something like:
|
@guolinke OK. Just |
Yeah, I think it is this, under Microsoft MIT license. |
@guolinke Got it! I'll create PR for this. |
@guolinke Can all header files be moved to
|
@StrikerRUS |
@guolinke Oh, I see. Thanks for the explanation! |
I think we may not check header guards because there are some problems with tests for them: cpplint/cpplint#44.
Total errors found: 203 Report (Clickable):
|
@guolinke It seems to me that there are no errors anymore which I can address. Maybe you can? All remaining issues we can mark as |
@StrikerRUS It looks good to me. Thanks very much for your great work! |
@guolinke No problem! I can help with |
Total errors found: 210 Report (Clickable):
|
@guolinke Are we planning implementing |
@StrikerRUS I think we could add them, but I don't have much spare time for it now. |
Total errors found: 225 Report (Clickable):
|
Huh, 853 -> 49! I believe we are almost done with this issue and will be able to enable cpplint check at CI in the near future. |
woo! @StrikerRUS I could make a PR for the whitespace and braces ones if you don't already have one. |
@jameslamb Sure, please do it! |
@StrikerRUS |
Total errors found: 44 Report (Clickable):
|
Total errors found: 44 Report (Clickable):
|
Total errors found: 42 Report (Clickable):
|
Total errors found: 40 Report (Clickable)
|
Total errors found: 39 Report (Clickable):
|
Total errors found: 4 Report (Clickable):
|
@guolinke We already have a PR for 1 (about |
🎉 🎉 🎉 🎉 🎉 🎉 🎉 Report (clickable)
We did it! Thanks for pushing this forward @StrikerRUS and for all the assistance @guolinke . Some of the linting issues fixed here were stylistic, but many were genuinely about the safety of the code, so I think all the effort here was well worth it. |
Style guide ref: http://google.github.io/styleguide/cppguide.html.
90127b5
Total errors found: 853
Report (Clickable):
The text was updated successfully, but these errors were encountered: