fixed cpplint errors and disable warning only for VS #2888
Conversation
| @@ -76,8 +76,10 @@ const int kAlignedSize = 32; | |||
| #define SIZE_ALIGNED(t) ((t) + kAlignedSize - 1) / kAlignedSize * kAlignedSize | |||
|
|
|||
| // Refer to https://docs.microsoft.com/en-us/cpp/error-messages/compiler-warnings/compiler-warning-level-4-c4127?view=vs-2019 | |||
| #pragma warning(disable : 4127) | |||
| #ifdef _MSC_VER | |||
| #pragma warning(disable : 4127) | |||
There was a problem hiding this comment.
Maybe some other warning disable could use the msc ver?
There was a problem hiding this comment.
@guolinke Sorry, didn't get it. Can you please elaborate?
There was a problem hiding this comment.
I means, there are some other #pragma warning(disable : xxxx), which are not inside #ifdef _MSC_VER.
There was a problem hiding this comment.
Ah, got it! I thought that the reference to VS in the corresponding comment means that it is actually needed only for VS. Like in
LightGBM/include/LightGBM/utils/openmp_wrapper.h
Lines 68 to 70 in 6b6709b
And I was aware only about that pragma warning in openmp_wrapper code. Should I search for others and wrap them as well?
There was a problem hiding this comment.
yeah, I remember there are some in c_api.
Refer to #1990 and #2883.