Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed cpplint error about namespace using-directives #2836

Merged
merged 1 commit into from
Feb 28, 2020
Merged

fixed cpplint error about namespace using-directives #2836

merged 1 commit into from
Feb 28, 2020

Conversation

StrikerRUS
Copy link
Collaborator

Refer to #1990.

Fix error

Do not use namespace using-directives.  Use using-declarations instead.  [build/namespaces] [5]

I don't know how to fix 2 remaining errors here:

LightGBM/src/c_api.cpp

Line 546 in e502ed0

using namespace LightGBM;

LightGBM/src/lightgbm_R.cpp

Line 36 in e502ed0

using namespace LightGBM;

@StrikerRUS StrikerRUS merged commit 53137e2 into master Feb 28, 2020
@StrikerRUS StrikerRUS deleted the cpplint branch February 28, 2020 11:38
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@guolinke guolinke guolinke approved these changes

@chivee chivee Awaiting requested review from chivee

Assignees
No one assigned
Labels
maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StrikerRUS @guolinke