Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor micro-ROS custom APIs #103

Merged
merged 11 commits into from
May 5, 2021
Merged

Conversation

@pablogs9 pablogs9 requested a review from jamoralp February 11, 2021 08:21
@pablogs9 pablogs9 marked this pull request as draft February 11, 2021 08:24
@pablogs9 pablogs9 marked this pull request as ready for review February 15, 2021 08:47
@Acuadros95 Acuadros95 force-pushed the feature/refactor_microros_api branch from 2da27ac to 7df8566 Compare May 5, 2021 08:23
@github-actions
Copy link

github-actions bot commented May 5, 2021

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B

@codecov-commenter
Copy link

codecov-commenter commented May 5, 2021

Codecov Report

Merging #103 (179411b) into foxy (a3db073) will not change coverage.
The diff coverage is 40.95%.

Impacted file tree graph

@@           Coverage Diff           @@
##             foxy     #103   +/-   ##
=======================================
  Coverage   48.01%   48.01%           
=======================================
  Files          35       39    +4     
  Lines        1487     1487           
  Branches      303      303           
=======================================
  Hits          714      714           
  Misses        567      567           
  Partials      206      206           
Impacted Files Coverage Δ
rmw_microxrcedds_c/src/rmw_init.c 63.20% <ø> (ø)
rmw_microxrcedds_c/src/rmw_microros/init_options.c 0.00% <0.00%> (ø)
rmw_microxrcedds_c/src/rmw_publish.c 46.34% <ø> (ø)
rmw_microxrcedds_c/src/rmw_microros/time_sync.c 40.62% <40.62%> (ø)
rmw_microxrcedds_c/src/rmw_microros/discovery.c 65.00% <65.00%> (ø)
rmw_microxrcedds_c/src/rmw_microros/ping.c 78.57% <78.57%> (ø)
...cedds_c/src/rmw_microros/continous_serialization.c 100.00% <100.00%> (ø)
rmw_microxrcedds_c/src/rmw_uxrce_transports.c 75.00% <100.00%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a3db073...179411b. Read the comment docs.

@github-actions
Copy link

github-actions bot commented May 5, 2021

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B

@pablogs9 pablogs9 removed the request for review from jamoralp May 5, 2021 09:17
@pablogs9
Copy link
Member Author

pablogs9 commented May 5, 2021

@Acuadros95 is possible to remove eProsimas references from the Doxygen? I guess that with the default template should be ok.

@github-actions
Copy link

github-actions bot commented May 5, 2021

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B

@github-actions
Copy link

github-actions bot commented May 5, 2021

Static memory analysis

Default configuration

MTU: 512 B
Input buffer size: 2048 B
Input history: 4
Output buffer size: 2048 B
Output history: 4

Entity Qty Size per unit
Context 1 5584 B
Topic 12 56 B
Service 4 80 B
Client 4 72 B
Subscription 4 168 B
Publisher 8 184 B
Node 4 56 B
Static input buffer 8 2120 B

TOTAL: 25020 B

@pablogs9 pablogs9 merged commit e63896d into foxy May 5, 2021
@pablogs9 pablogs9 deleted the feature/refactor_microros_api branch May 5, 2021 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants