Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wet bulb freezing level #1949

Merged
merged 10 commits into from
Oct 10, 2023
65 changes: 65 additions & 0 deletions improver/cli/wet_bulb_freezing_level.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,65 @@
#!/usr/bin/env python
# -*- coding: utf-8 -*-
# -----------------------------------------------------------------------------
# (C) British Crown copyright. The Met Office.
# All rights reserved.
#
# Redistribution and use in source and binary forms, with or without
# modification, are permitted provided that the following conditions are met:
#
# * Redistributions of source code must retain the above copyright notice, this
# list of conditions and the following disclaimer.
#
# * Redistributions in binary form must reproduce the above copyright notice,
# this list of conditions and the following disclaimer in the documentation
# and/or other materials provided with the distribution.
#
# * Neither the name of the copyright holder nor the names of its
# contributors may be used to endorse or promote products derived from
# this software without specific prior written permission.
#
# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
# AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
# IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
# ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE
# LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
# CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
# SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
# INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
# CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
# ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
# POSSIBILITY OF SUCH DAMAGE.
"""CLI to extract wet-bulb freezing level from wet-bulb temperature on height levels"""

from improver import cli


@cli.clizefy
@cli.with_output
def process(wet_bulb_temperature: cli.inputcube):
"""Module to generate wet-bulb freezing level.

The height level at which the wet-bulb temperature first drops below 237.15K
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The height level at which the wet-bulb temperature first drops below 237.15K
The height level at which the wet-bulb temperature first drops below 273.15K

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

(0 degrees Celsius) is extracted from the wet-bulb temperature cube.

In grid squares where the temperature never goes below 237.15K the highest
height level on the cube is returned. In grid square where the temperature
brhooper marked this conversation as resolved.
Show resolved Hide resolved
starts below 237.15K the lowest height on the cube is returned.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In grid squares where the temperature never goes below 237.15K the highest
height level on the cube is returned. In grid square where the temperature
starts below 237.15K the lowest height on the cube is returned.
In grid squares where the temperature never goes below 273.15K the highest
height level on the cube is returned. In grid square where the temperature
starts below 273.15K the lowest height on the cube is returned.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done


Args:
wet_bulb_temperature (iris.cube.Cube):
Cube of wet-bulb air temperatures over multiple height levels.

Returns:
iris.cube.Cube:
Cube of wet-bulb freezing level.

"""
from improver.utilities.cube_extraction import ExtractLevel

wet_bulb_freezing_level = ExtractLevel(
positive_correlation=False, value_of_level=273.15
)(wet_bulb_temperature)
wet_bulb_freezing_level.rename("wet_bulb_freezing_level")

return wet_bulb_freezing_level
10 changes: 4 additions & 6 deletions improver/psychrometric_calculations/hail_size.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
saturated_humidity,
)
from improver.utilities.cube_checker import assert_spatial_coords_match
from improver.utilities.cube_extraction import ExtractPressureLevel
from improver.utilities.cube_extraction import ExtractLevel
from improver.utilities.cube_manipulation import enforce_coordinate_ordering


Expand Down Expand Up @@ -525,18 +525,16 @@ def process(
wet_bulb_zero_height_asl,
orography,
)
extract_pressure = ExtractPressureLevel(
value_of_pressure_level=268.15, positive_correlation=True
extract_pressure = ExtractLevel(
value_of_level=268.15, positive_correlation=True
)
pressure_at_268 = extract_pressure(temperature_on_pressure)

temperature_at_268 = next(temperature_on_pressure.slices_over(["pressure"]))
temperature_at_268.rename("temperature_of_atmosphere_at_268.15K")
temperature_at_268.remove_coord("pressure")
temperature = np.full_like(
temperature_at_268.data,
extract_pressure.value_of_pressure_level,
dtype=np.float32,
temperature_at_268.data, extract_pressure.value_of_level, dtype=np.float32,
)
temperature = np.ma.masked_where(np.ma.getmask(pressure_at_268), temperature)
temperature_at_268.data = temperature
Expand Down
Loading