-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wet bulb freezing level #1949
Wet bulb freezing level #1949
Conversation
…l and updates unit tests
…me unit test file name.
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1949 +/- ##
==========================================
- Coverage 98.38% 98.38% -0.01%
==========================================
Files 123 123
Lines 11792 11783 -9
==========================================
- Hits 11602 11593 -9
Misses 190 190
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a doc-string change needed.
A comment for your notebook: Surface temperature inversions like your final example are quite common, although they are usually much shallower than that. We won't have seen this in the hail output because surface temperature inversions are associated with stable, nocturnal, non-convective weather, when hail is not possible.
def process(wet_bulb_temperature: cli.inputcube): | ||
"""Module to generate wet-bulb freezing level. | ||
|
||
The height level at which the wet-bulb temperature first drops below 237.15K |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The height level at which the wet-bulb temperature first drops below 237.15K | |
The height level at which the wet-bulb temperature first drops below 273.15K |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
In grid squares where the temperature never goes below 237.15K the highest | ||
height level on the cube is returned. In grid square where the temperature | ||
starts below 237.15K the lowest height on the cube is returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In grid squares where the temperature never goes below 237.15K the highest | |
height level on the cube is returned. In grid square where the temperature | |
starts below 237.15K the lowest height on the cube is returned. | |
In grid squares where the temperature never goes below 273.15K the highest | |
height level on the cube is returned. In grid square where the temperature | |
starts below 273.15K the lowest height on the cube is returned. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mspelman07, I've just added a few comments, mostly about docstrings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mspelman07, I'm happy to approve this now
* Updates ExtractPressureLevel to also be able to extract a height level and updates unit tests * Update plugin to use stratify's extrapolation * Adds acceptance tests and cli for wet bulb freezing level. ALlso rename unit test file name. * Updates to hail size plugin * Formatting * Update checksums and uncommenting * update docstring formatting * doc string updated * review response * formatting review changes --------- Co-authored-by: Marcus Spelman <[email protected]>
This PR adds in the ability to calculate a Wet bulb freezing level from a wet-bulb temperature on height levels.
Most of the changes for this PR are simply renaming variables to be more agnostic and apply to height and pressure coordinates rather than just pressure. The main changes are for the plugin ExtractPressureLevel (renamed to ExtractLevel). The core changes in this PR are:
To show my changes to the ExtractLevel plugin haven't changed how the plugin works (except where they should change it) I have plotted a few profiles of what it extracted previously and what it extracts now (https://github.com/MetOffice/improver_aux/blob/extractpressure_behaviour/notebooks/Checking_changes_to_ExtractPressureLevels.ipynb)
Acceptance_test_data: metoppv/improver_test_data#30
Testing: