MOBT-246: Remove flawed interpretation of the blend_time coordinate #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1690 +/- ##
==========================================
- Coverage 98.17% 98.17% -0.01%
==========================================
Files 110 110
Lines 10207 10202 -5
==========================================
- Hits 10021 10016 -5
Misses 186 186
Continue to review full report at Codecov.
|
MoseleyS
approved these changes
Mar 8, 2022
gavinevans
approved these changes
Mar 8, 2022
There was a problem hiding this comment.
Thanks @bayliffe 👍
I think this makes sense as far as I currently understand the intended metadata behaviour.
fionaRust
added a commit
that referenced
this pull request
Mar 9, 2022
* master: Remove flawed interpretation of the blend_time coordinate. (#1690) DOC: Removal of unnecessary exclusions in sphinx apidoc build (#1689) MOBT127 tiny tweak to filter_realizations (#1682) Mobt 160 ecc masked data (#1662) Convert test_ManipulateReliabilityTable to pytest (#1678) Alter spot extract cli (#1666) Enable site cube input to ConstructReliabilityCalibrationTables (#1667) Corrects example of a CLI in the Read the Doc documentation (#1673) MOBT-211: mosg__model_run attribute handling in weather symbols (#1670)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes flawed interpretation of the blend_time coordinate as evidence of model blending having occurred. See https://github.com/metoppv/mo-blue-team/issues/246 for a long description of what's going on here.
Testing: