Alter spot extract cli #1666
Merged
Alter spot extract cli #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BelligerG
added
the
BoM review required
bayliffe
approved these changes
Feb 9, 2022
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 110 110
Lines 10110 10110
=======================================
Hits 9927 9927
Misses 183 183 Continue to review full report at Codecov.
|
tjtg
approved these changes
Feb 10, 2022
cpelley
reviewed
Feb 11, 2022
| elif apply_lapse_rate_correction and not lapse_rate: | ||
| if not suppress_warnings: | ||
| if apply_lapse_rate_correction: | ||
| if len(cubes) == 3: |
There was a problem hiding this comment.
Was a constrained load based on metadata not possible in identifying lapse_rate etc. rather than relying on cube ordering?
There was a problem hiding this comment.
Possibly, but it wouldn't fit the pattern for other CLIs. It is something we should look at in the future though
cpelley
approved these changes
Feb 14, 2022
MoseleyS
added a commit
to MoseleyS/improver
that referenced
this pull request
Mar 2, 2022
* master: MOBT127 tiny tweak to filter_realizations (metoppv#1682) Mobt 160 ecc masked data (metoppv#1662) Convert test_ManipulateReliabilityTable to pytest (metoppv#1678) Alter spot extract cli (metoppv#1666) Enable site cube input to ConstructReliabilityCalibrationTables (metoppv#1667) Corrects example of a CLI in the Read the Doc documentation (metoppv#1673) MOBT-211: mosg__model_run attribute handling in weather symbols (metoppv#1670) # Conflicts: # improver_tests/wxcode/wxcode/test_WeatherSymbols.py
fionaRust
added a commit
that referenced
this pull request
Mar 9, 2022
* master: Remove flawed interpretation of the blend_time coordinate. (#1690) DOC: Removal of unnecessary exclusions in sphinx apidoc build (#1689) MOBT127 tiny tweak to filter_realizations (#1682) Mobt 160 ecc masked data (#1662) Convert test_ManipulateReliabilityTable to pytest (#1678) Alter spot extract cli (#1666) Enable site cube input to ConstructReliabilityCalibrationTables (#1667) Corrects example of a CLI in the Read the Doc documentation (#1673) MOBT-211: mosg__model_run attribute handling in weather symbols (#1670)
MoseleyS
pushed a commit
to MoseleyS/improver
that referenced
this pull request
Aug 22, 2024
* Altered interface of spot extract * updated dosctring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altering the spot extract CLI to be more consistent with the rest of improver, closes #1659.