mission: import null as NaN #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When QGC sets a param as `null` it means unchanged which should translate to NaN for mavlink mission items.
We should add the functionality to support the yaw setting and then test this here as well.
|
According to @nicovanduijn this still doesn't work. |
| @@ -1203,7 +1203,12 @@ Mission::Result MissionImpl::import_mission_items(Mission::mission_items_t &all_ | |||
| // Extract parameters of each mission item | |||
| std::vector<double> params; | |||
| for (auto &p : json_mission_item["params"].array_items()) { | |||
| params.push_back(p.number_value()); | |||
| if (p.is_null()) { | |||
There was a problem hiding this comment.
Does this check for null rightly ?
There was a problem hiding this comment.
From my tests, yes.
There was a problem hiding this comment.
Then, its fine.
|
I think QGC should stick to using NaN rather. Isn't it ? |
I think |
|
@shakthi-prashanth-m agreed? |
Oh yeah. Sure agreed. |
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
mission: import null as NaN
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When QGC sets a param as
nullit means unchanged which shouldtranslate to NaN for mavlink mission items.
Fixes #422.