mission: warn if changing takeoff/land to waypoint #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should not silently change takeoff or land mission items to waypoints. We should at least warn the user about it, even though PX4 is supposed to do the right thing.
|
@julianoes , I remember testing mission containing "Land" item which successfully landed. Did you mean this ? |
shakthi-prashanth-m
approved these changes
Jun 8, 2018
rt-2pm2
pushed a commit
to rt-2pm2/DronecodeSDK
that referenced
this pull request
Nov 27, 2018
mission: warn if changing takeoff/land to waypoint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not silently change takeoff or land mission items to
waypoints. We should at least warn the user about it, even though PX4 is
supposed to do the right thing.
@shakthi-prashanth-m I know that PX4 handles a missing takeoff item fine but what happens when a land item is changed?
FYI @nicovanduijn
Related to #286.