Update go.sum after golang.org/x/sys update #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
=======================================
Coverage 44.00% 44.00%
=======================================
Files 3 3
Lines 75 75
=======================================
Hits 33 33
Misses 40 40
Partials 2 2 Continue to review full report at Codecov.
|
|
@mattn could you please take a look? |
|
Once go get -u again please. |
PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't update go.sum. This leads to the following error on running go.test.sh: go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys Fix this by running go get -u && go mod tidy to update golang.org/x/sys and clean up go.sum.
Done and force pushed. |
|
@mattn friendly ping |
|
Thank you |
guonaihong
added a commit
to guonaihong/gout
that referenced
this pull request
Jan 2, 2022
在mac电脑上使用go1.17 以及sys库会导致runtime SIGSEGV gout 会使用go-isatty判断终端, 该库直接依赖sys库, 导致gout间接依赖sys库 mattn/go-isatty#68 所以更新下
guonaihong
added a commit
to guonaihong/gout
that referenced
this pull request
Jan 2, 2022
在mac电脑上使用go1.17 以及sys库会导致runtime SIGSEGV gout 会使用go-isatty判断终端, 该库直接依赖sys库, 导致gout间接依赖sys库 mattn/go-isatty#68 所以更新下
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #66 updated the golang.org/x/sys dependency in go.mod but didn't
update go.sum. This leads to the following error on running go.test.sh:
Fix this by running go mod download golang.org/x/sys && go mod tidy to
update and clean up go.sum.