Update golang.org/x/sys commit hash to 0f9fa26a #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
=======================================
Coverage 44.00% 44.00%
=======================================
Files 3 3
Lines 75 75
=======================================
Hits 33 33
Misses 40 40
Partials 2 2 Continue to review full report at Codecov.
|
|
Thank you |
|
Tagged v0.0.14 |
|
Thanks @mattn, much appreciated! |
timoreimann
pushed a commit
to digitalocean/clusterlint
that referenced
this pull request
Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. [1] mattn/go-isatty#66
timoreimann
pushed a commit
to digitalocean/clusterlint
that referenced
this pull request
Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. Updating github.com/fatih/color as well while we're here. [1] mattn/go-isatty#66
timoreimann
pushed a commit
to digitalocean/clusterlint
that referenced
this pull request
Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. Also bump the minimum (library) dependency to 1.16 in go.mod since that is the oldest, officially supported Go version. Bumping to 1.17 actually enables us to fix the issue by simply updating to the latest github.com/fatih/color, as opposed to adding an indirect import of github.com/mattn/go-isatty which this change does right now (which I suppose works due to Go 1.17 module management improvements); however, that'd come at the price of breaking compatibility with 1.16 users which is non-ideal. Regardless, update github.com/fatih/color as well while we're here. Also bump the version of the Go image used for testing. [1] mattn/go-isatty#66
timoreimann
pushed a commit
to digitalocean/clusterlint
that referenced
this pull request
Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. Also bump the minimum (library) dependency to 1.16 in go.mod since that is the oldest, officially supported Go version. Bumping to 1.17 actually enables us to fix the issue by simply updating to the latest github.com/fatih/color, as opposed to adding an indirect import of github.com/mattn/go-isatty which this change does right now (which I suppose works due to Go 1.17 module management improvements); however, that'd come at the price of breaking compatibility with 1.16 users which is non-ideal. Regardless, update github.com/fatih/color as well while we're here. Also bump the version of the Go image used for testing. [1] mattn/go-isatty#66
timoreimann
pushed a commit
to digitalocean/clusterlint
that referenced
this pull request
Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. Also bump the minimum (library) dependency to 1.16 in go.mod since that is the oldest, officially supported Go version. Bumping to 1.17 actually enables us to fix the issue by simply updating to the latest github.com/fatih/color, as opposed to adding an indirect import of github.com/mattn/go-isatty which this change does right now (which I suppose works due to Go 1.17 module management improvements); however, that'd come at the price of breaking compatibility with 1.16 users which is non-ideal. Regardless, update github.com/fatih/color as well while we're here. Also bump the version of the Go image used for testing. [1] mattn/go-isatty#66
timoreimann
pushed a commit
to digitalocean/clusterlint
that referenced
this pull request
Sep 19, 2021
When running clusterlint on Go 1.17, it panics right on startup. The issue is our usage of github.com/mattn/go-isatty (consumed by github.com/fatih/color) which had a bug until [1]. Updating to the latest v0.0.14 release fixes the issue. Also bump the minimum (library) dependency to 1.16 in go.mod since that is the oldest, officially supported Go version. Bumping to 1.17 actually enables us to fix the issue by simply updating to the latest github.com/fatih/color, as opposed to adding an indirect import of github.com/mattn/go-isatty which this change does right now (which I suppose works due to Go 1.17 module management improvements); however, that'd come at the price of breaking compatibility with 1.16 users which is non-ideal. Regardless, update github.com/fatih/color as well while we're here. Also bump the version of the Go image used for testing. [1] mattn/go-isatty#66
tklauser
added a commit
to tklauser/go-isatty
that referenced
this pull request
Sep 29, 2021
PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't update go.sum. This leads to the following error on running go.test.sh: go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys Fix this by running go mod download golang.org/x/sys && go mod tidy to update and clean up go.sum.
tklauser
added a commit
to tklauser/go-isatty
that referenced
this pull request
Sep 29, 2021
PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't update go.sum. This leads to the following error on running go.test.sh: go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys Fix this by running go mod download golang.org/x/sys && go mod tidy to update and clean up go.sum.
tklauser
added a commit
to tklauser/go-isatty
that referenced
this pull request
Oct 5, 2021
PR mattn#66 updated the golang.org/x/sys dependency in go.mod but didn't update go.sum. This leads to the following error on running go.test.sh: go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys go: golang.org/x/[email protected]: missing go.sum entry; to add it: go mod download golang.org/x/sys Fix this by running go get -u && go mod tidy to update golang.org/x/sys and clean up go.sum.
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed go 1.17 panic
fatal error: unexpected signal during runtime execution
Related links golang/go#47279