Handle malformed events more gracefully #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
But handle unusual events. With regression test. Fixes #223
DMRobertson
reviewed
Jul 25, 2023
Comment on lines
+458
to
+460
| logger.Warn().Str("event_id", ev.ID).Err(err).Msg( | ||
| "filterAndEnsureFieldsSet: failed to parse event, ignoring", | ||
| ) |
There was a problem hiding this comment.
Probably want to log room ID here too.
DMRobertson
approved these changes
Jul 25, 2023
There was a problem hiding this comment.
TestEventTableMembershipDetection is failing. Not sure if related or if it's just a flake?
You should probably also take a look at https://sentry.tools.element.io/organizations/element/issues/69559/?project=56&query=is%3Aunresolved if you haven't already.
json: cannot unmarshal number 18446744073407678578 into Go struct field receiptInfo.content.m.read.ts of type int64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But handle unusual events. With regression test.