Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Receiving malformed events should not cascade fail timeline processing #223

Closed
kegsay opened this issue Jul 25, 2023 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@kegsay
Copy link
Member

kegsay commented Jul 25, 2023

Some rooms seem to have invalid events missing a type key. This causes the proxy to get upset:

ERR V2: failed to accumulate room error="filterTimelineEvents: event malformed: event JSON missing type key"

When this happens when processing a timeline block, it causes the entire timeline block to be ignored, rather than just the malformed event. In practice, we probably just want to ignore the malformed event and continue on, rather than drop valid events that happen to be alongside the malformed event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants