Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic release created for v1.0.0-beta.5 #2051

Merged
merged 8 commits into from
Feb 22, 2019

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Feb 22, 2019

Changed

  • Removed Vue error handling to bubble errors to the console, this doesn't effect users @faboweb

Fixed

  • Validator page shows now correctly by avoiding async errors @faboweb
  • Stylelint configuration and scripts work as expected (no longer in webpack) @jbibla

jleni and others added 8 commits February 21, 2019 08:31
Redirecting dependency to cosmos repo
* fixed page validator issues

* added test cases

* updated snapshot

* Update PageValidator.vue

* updated snapshots

* Update app/src/renderer/vuex/getters.js

Co-Authored-By: faboweb <[email protected]>
* stylelint fixes
* removed prettier, fixed lint
* added .nvmrc file
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #2051 into master will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
- Coverage   95.51%   95.48%   -0.04%     
==========================================
  Files         112      112              
  Lines        2544     2547       +3     
  Branches      116      120       +4     
==========================================
+ Hits         2430     2432       +2     
  Misses        106      106              
- Partials        8        9       +1
Impacted Files Coverage Δ
app/src/renderer/scripts/boot.js 96.77% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 92.3% <ø> (ø) ⬆️
...p/src/renderer/components/common/TmModalSearch.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️
...src/renderer/components/common/TmSessionSignUp.vue 100% <ø> (ø) ⬆️
...rc/renderer/components/staking/DelegationModal.vue 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.48% <75%> (-1.52%) ⬇️

1 similar comment
@codecov
Copy link

codecov bot commented Feb 22, 2019

Codecov Report

Merging #2051 into master will decrease coverage by 0.03%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master    #2051      +/-   ##
==========================================
- Coverage   95.51%   95.48%   -0.04%     
==========================================
  Files         112      112              
  Lines        2544     2547       +3     
  Branches      116      120       +4     
==========================================
+ Hits         2430     2432       +2     
  Misses        106      106              
- Partials        8        9       +1
Impacted Files Coverage Δ
app/src/renderer/scripts/boot.js 96.77% <ø> (ø) ⬆️
app/src/renderer/vuex/getters.js 92.3% <ø> (ø) ⬆️
...p/src/renderer/components/common/TmModalSearch.vue 100% <ø> (ø) ⬆️
app/src/renderer/components/common/Page404.vue 100% <ø> (ø) ⬆️
...src/renderer/components/common/TmSessionSignUp.vue 100% <ø> (ø) ⬆️
...rc/renderer/components/staking/DelegationModal.vue 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 98.48% <75%> (-1.52%) ⬇️

@jbibla jbibla merged commit 2f2b96d into master Feb 22, 2019
@jbibla jbibla deleted the release-candidate/v1.0.0-beta.5 branch February 22, 2019 10:27
@jbibla jbibla restored the release-candidate/v1.0.0-beta.5 branch February 22, 2019 10:40
@jbibla jbibla deleted the release-candidate/v1.0.0-beta.5 branch February 22, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants