Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirecting dependency to cosmos repo #2033

Merged
merged 2 commits into from
Feb 21, 2019
Merged

Redirecting dependency to cosmos repo #2033

merged 2 commits into from
Feb 21, 2019

Conversation

jleni
Copy link
Contributor

@jleni jleni commented Feb 21, 2019

Closes #2031

Description:

Now voyager will point directly to cosmos/ledger-cosmos-js


For contributor:

  • Added entries in CHANGELOG.md with issue # and GitHub username
  • Reviewed Files changed in the github PR explorer
  • Attach screenshots of the UI components on the PR description (if applicable)
  • Scope of work approved for big PRs

For reviewer:

  • Manually tested the changes on the UI

@faboweb
Copy link
Collaborator

faboweb commented Feb 21, 2019

Could you please update the changelog?

@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #2033 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2033   +/-   ##
========================================
  Coverage    95.51%   95.51%           
========================================
  Files          112      112           
  Lines         2544     2544           
  Branches       116      116           
========================================
  Hits          2430     2430           
  Misses         106      106           
  Partials         8        8

1 similar comment
@codecov
Copy link

codecov bot commented Feb 21, 2019

Codecov Report

Merging #2033 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #2033   +/-   ##
========================================
  Coverage    95.51%   95.51%           
========================================
  Files          112      112           
  Lines         2544     2544           
  Branches       116      116           
========================================
  Hits          2430     2430           
  Misses         106      106           
  Partials         8        8

@jleni
Copy link
Contributor Author

jleni commented Feb 21, 2019

Could you please update the changelog?

yep, I was just doing that! :)

@faboweb
Copy link
Collaborator

faboweb commented Feb 21, 2019

Sorry, hahahhaha I was too quick. Thanks for this PR! :)

@faboweb faboweb merged commit 3c44a81 into luniehq:develop Feb 21, 2019
@jbibla
Copy link
Collaborator

jbibla commented Feb 21, 2019

thank you @jleni!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants