Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabo/1154 use explorer validator page #1164

Merged
merged 16 commits into from
Aug 21, 2018

Conversation

faboweb
Copy link
Collaborator

@faboweb faboweb commented Aug 20, 2018

Closes #1154, #1100

image
image

❤️ Thank you!

@faboweb faboweb requested review from NodeGuy and nylira as code owners August 20, 2018 15:02
@codecov
Copy link

codecov bot commented Aug 20, 2018

Codecov Report

Merging #1164 into develop will increase coverage by 0.05%.
The diff coverage is 100%.

@@             Coverage Diff             @@
##           develop    #1164      +/-   ##
===========================================
+ Coverage    95.88%   95.94%   +0.05%     
===========================================
  Files           79       80       +1     
  Lines         1579     1601      +22     
  Branches        74       75       +1     
===========================================
+ Hits          1514     1536      +22     
- Misses          58       59       +1     
+ Partials         7        6       -1
Impacted Files Coverage Δ
app/src/renderer/connectors/lcdClientMock.js 97.45% <ø> (ø) ⬆️
app/src/renderer/routes.js 100% <ø> (ø) ⬆️
app/src/renderer/components/staking/LiDelegate.vue 91.66% <ø> (ø) ⬆️
app/src/renderer/vuex/modules/delegates.js 100% <100%> (ø) ⬆️
.../src/renderer/components/staking/PageValidator.vue 100% <100%> (ø)
app/src/renderer/components/common/AnchorCopy.vue 100% <100%> (ø)
...pp/src/renderer/components/staking/PageStaking.vue 100% <100%> (ø) ⬆️
app/src/renderer/components/common/TextBlock.vue 33.33% <0%> (-66.67%) ⬇️

@faboweb faboweb changed the title Fabo/1154 use explorer validator page WIP: Fabo/1154 use explorer validator page Aug 20, 2018
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 20, 2018

Keybase is throttling this PR: GET https://keybase.io/_/api/1.0/user/lookup.json?key_suffix=[do-not-modify] 429 (Too Many Requests)

@faboweb faboweb changed the title WIP: Fabo/1154 use explorer validator page Fabo/1154 use explorer validator page Aug 21, 2018
Copy link
Collaborator

@jbibla jbibla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there security concerns that come with requesting photos from keybase?

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@fedekunze fedekunze merged commit bbaca9b into develop Aug 21, 2018
@fedekunze fedekunze deleted the fabo/1154-use-explorer-validator-page branch August 21, 2018 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Voyager use Explorer's page for displaying validator information.
4 participants