Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display more info about validators #1100

Closed
fedekunze opened this issue Aug 8, 2018 · 12 comments
Closed

Display more info about validators #1100

fedekunze opened this issue Aug 8, 2018 · 12 comments
Labels
blocked ✋ issues blocked by other implementations/issues

Comments

@fedekunze
Copy link
Contributor

fedekunze commented Aug 8, 2018 •
edited
Loading

UI Version: 0.9.3

Description:

Would be a nice to have to display the same information as the explorer as well as other important information within the Validator Profile:

Validator Struct Explorer Voyager
Owner ✅ ⛔️
PubKey ✅ ⛔️
Revoked ✅ ⛔️
Status ✅ ⛔️
Tokens ⛔️ ⛔️
DelegatorShares ⛔️ ⛔️
Moniker ✅ ✅
Identity ✅ ⛔️
Website ✅ ✅
Details ✅ ✅
BondHeight ✅ ⛔️
BondIntraTxCounter ⛔️ ⛔️
ProposerRewardPool ⛔️ ⛔️
Commission ⛔️ ⛔️
CommissionMax ⛔️ ⛔️
DelegatorShares ⛔️ ⛔️
CommissionChangeRate ⛔️ ⛔️
CommissionChangeRateToday ⛔️ ⛔️
LastBondedTokens ⛔️ ⛔️

Also both of them have Total Vote Power. It would be nice to also show the stake and delegator shares as well as the total vote power
@jbibla
Copy link
Collaborator

jbibla commented Aug 8, 2018

thanks @fedekunze this is super helpful. we should actually share this component in tendermint/ui...

@okwme okwme self-assigned this Aug 14, 2018
@faboweb faboweb removed the discuss label Aug 14, 2018
@fedekunze fedekunze mentioned this issue Aug 14, 2018
Closed
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 14, 2018 •
edited
Loading

Nice table!

So Jordon, you're suggesting that we move app/src/renderer/components/staking/PageDelegate.vue into @tendermint/ui?

@jbibla
Copy link
Collaborator

jbibla commented Aug 15, 2018

yes, because the explorer has a validator list and profile page.

@faboweb faboweb mentioned this issue Aug 16, 2018
Closed
@NodeGuy NodeGuy mentioned this issue Aug 16, 2018
Closed
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 16, 2018

I created a new issue for that: #1152

@NodeGuy NodeGuy mentioned this issue Aug 19, 2018
Closed
@NodeGuy
Copy link
Contributor

NodeGuy commented Aug 19, 2018 •
edited
Loading

Blocked by #1152.

@NodeGuy NodeGuy added the blocked ✋ issues blocked by other implementations/issues label Aug 19, 2018
@faboweb
Copy link
Collaborator

faboweb commented Aug 20, 2018 •
edited
Loading

Proposal:
image
image

I converted DelegatorShares into Self Bond as I think this is the actual interesting value.
Do we need BondIntraTxCounter (what is that?) and ProposerRewardPool? I think those are only used internally together with LastBondedTokens. Correct me if I am wrong.

Pulling in @fedekunze

@faboweb
Copy link
Collaborator

faboweb commented Aug 20, 2018

@nylira what about a default avatar?

@fedekunze
Copy link
Contributor Author

@faboweb Imo LastBondedTokens are useful. They are printed on the SDK as Previous Bonded Tokens: LastBondedTokens. Same with ProposerRewardPool and CommissionChangeToday. We can leave BondIntraTxCounter out

  • ProposerRewardPool : the reward pool collected from being the proposer
  • BondIntraTxCounter: block-local tx index of validator change

@faboweb
Copy link
Collaborator

faboweb commented Aug 20, 2018 •
edited
Loading

How would you base decisions on LastBondedTokens or ProposerRewardPool?

@jbibla
Copy link
Collaborator

jbibla commented Aug 20, 2018

what about a default avatar?

please use this icon: https://drive.google.com/open?id=11_B4Q5SsErJ4G5v2VermpCbumYX2wU-U

@faboweb
Copy link
Collaborator

faboweb commented Aug 20, 2018

Updated the screenshots.

@faboweb faboweb mentioned this issue Aug 20, 2018
Merged
@fedekunze
Copy link
Contributor Author

closed by #1164

@faboweb faboweb unassigned okwme and NodeGuy Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked ✋ issues blocked by other implementations/issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@okwme @NodeGuy @faboweb @jbibla @fedekunze