Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The process is not quitting if the electron window gets closed #62

Closed
faboweb opened this issue Nov 16, 2017 · 9 comments
Closed

The process is not quitting if the electron window gets closed #62

faboweb opened this issue Nov 16, 2017 · 9 comments
Assignees
@faboweb
Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed

Comments

@faboweb
Copy link
Collaborator

faboweb commented Nov 16, 2017 •
edited
Loading

No description provided.

@faboweb faboweb added the bug 🐛 issues related to unhandled errors in the code that need to be fixed label Nov 16, 2017
@faboweb faboweb mentioned this issue Nov 17, 2017
Closed
@faboweb
Copy link
Collaborator Author

faboweb commented Nov 17, 2017

In development webpack-dev-server does not terminate on kill command leaving the port blocked.

@faboweb faboweb mentioned this issue Nov 23, 2017
Closed
@jbibla
Copy link
Collaborator

jbibla commented Dec 11, 2017

this is done.

@jbibla jbibla closed this as completed Dec 11, 2017
@faboweb
Copy link
Collaborator Author

faboweb commented Dec 12, 2017

Did u test this? @jolesbi

@jbibla
Copy link
Collaborator

jbibla commented Dec 12, 2017

no. i assumed #63 and #102 addressed this... you're right. it's still an issue.

@jbibla jbibla reopened this Dec 12, 2017
This was referenced Dec 27, 2017
Closed
Merged
@jbibla
Copy link
Collaborator

jbibla commented Jan 11, 2018

this is still an issue for me sometimes...

gaia: ERROR: listen tcp :8998: bind: address already in use

@jbibla jbibla reopened this Jan 11, 2018
@jbibla
Copy link
Collaborator

jbibla commented Jan 11, 2018 •
edited
Loading

@faboweb i think this was because i was trying to run cosmos locally while i had the .dmg running. is this is an issue? if not, just close again. 😄

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 12, 2018

Yes it is. The port is hardcoded. We could make it dynamic. It is a rare case, that the user runs the installed app and the dev app. But there could be other software blocking the port.

@faboweb
Copy link
Collaborator Author

faboweb commented Jan 12, 2018

Additionally we could make the production port different then the dev port.

@jbibla
Copy link
Collaborator

jbibla commented Jan 12, 2018

make the production port different then the dev port.

this sounds good to me.

@mappum what do you think?

This was referenced Jan 26, 2018
Merged
Merged
faboweb pushed a commit that referenced this issue Jun 2, 2020
@colw
Merge pull request #62 from luniehq/fabo/fix-sent-tx
ea0295b 
Fabo/fix sent tx
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Fabo/wait for stargate to be up (#62)
55e5e43 
* debug missing denom

* do not call validators

* await for the remote instance to be up before loading static data

* remove logs

* remove fallback

* comment

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* Update cosmosV0-source.js
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Update production (#75)
5a468dc 
* added node install to docker

* run npm install correct

* don't copy modules

* use env variables for testnet

* Update pr.yml

* github workflows changes

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Make search case-insensitive (#36)

Modify variable names for clarity.

* Query balance by denomination (#48)

* colw/subscription-fix (#47)

* Fix transaction destructure

* Lint

* Rename for consistency

* Override method for V2

* Colw/fix denom and votes (#49)

* Use larger denom for governance parameters

* Lint

* Fix: Leave in big number format for line #86

* Fabo/minor fixes (#51)

* gracefully handle no rewards

* always return balance

* prevent error when no rewards

* fix wrong delegation amount showing

* log transaction if tag is empty (#58)

* fix tally for running proposals (#54)

* Fabo/move testnet definition into network configs file (#56)

* move testnet definition into network configs file

* use configs for endpoints

* update cache key per block (#57)

* colw/minor-fixes (#59)

* Export testnet data for use in LunieDB Source

* Fix get query

* Mario/32 add proposal proposer (#52)

* Add proposal proposer

* Add proposer to proposals page

* Revert package.js mod, use Promise.all

* Call all queries at same time in getProposalById

* Api error 500 fix

* Fabo suggestions

* Add cross-env

* Resolve merge conflict

* Fix merge error

* deliver correct testnet url (#60)

* Latest proposal should be on top (#61)

* Colin's magic

* const proposals

* fix to not crash if no denom

* Fabo/wait for stargate to be up (#62)

* debug missing denom

* do not call validators

* await for the remote instance to be up before loading static data

* remove logs

* remove fallback

* comment

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* colw/subscription-refactor (#63)

* Factor out subscription object

* WIP

* Reenable subs

* Do not pre-populate cache (temp)

This is run on every request.

* Reenable static data

* Fix

* Remove comment

* WIP

* Use API class within subscription object

* Update file and parameter naming

* Load API classes once.

* Revert "Load API classes once."

ca567095360dbd7a8d81c7a53fe4fe885f3b63d2

* Set headers in separate method

* format comment

* Rename class variable

* Split static data up

* Adjust cache timing, default 5

* Update lib/schema.js

Co-Authored-By: Fabian <[email protected]>

* Change client name to TendermintClient

* Comment and rename for clarity

* Cache specific blocks longer

* Move Tendermint client to CosmosNodeSubscription

* Comments for clarity

* Clear memory after handling each new block (#66)

* Fix typo and no return. (#68)

* Aleksei/sentry added (#67)

* only sentry init code added

* docker-compose changes

* inspect removed

* colw/Decrease validator list loading time (#69)

* Fetch validators each new block and store them

* Store block, and sync validator map with block

* Add block to store

* Remove unused parameters

* Retrieve a single validator form the map

* Review fix: remove height parameter

* Review fix: Change variable name for clarity

* Return delegations and rewards from store (#70)

* Return delegations and rewards from store

* overview values

* Remove unnecessary Promise.all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
bug 🐛 issues related to unhandled errors in the code that need to be fixed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mappum @faboweb @jbibla