Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use only one source for node_modules #47

Closed
faboweb opened this issue Nov 9, 2017 · 3 comments
Closed

Use only one source for node_modules #47

faboweb opened this issue Nov 9, 2017 · 3 comments
Assignees
@faboweb
Labels
low priority has been discussed, will be addressed later

Comments

@faboweb
Copy link
Collaborator

faboweb commented Nov 9, 2017

We have node_modules in root and in app/. This creates overhead while installing and is unpractically for testing as testing is done from root.
@faboweb
Copy link
Collaborator Author

faboweb commented Nov 21, 2017

This was more work then expected. I will defer that to a later time.

@faboweb faboweb added the low priority has been discussed, will be addressed later label Nov 21, 2017
@jbibla
Copy link
Collaborator

jbibla commented Dec 11, 2017 •
edited
Loading

since @jaekwon and @greg-szabo were discussing deterministic builds and human audit-able dependencies — this ticket might be worth doing sooner rather than later — for the sake of simplicity?

@faboweb
Copy link
Collaborator Author

faboweb commented Dec 12, 2017

We can take it into the next sprint. This should be easier now as everything is a lot more stable.

@faboweb faboweb self-assigned this Dec 28, 2017
@faboweb faboweb mentioned this issue Jan 3, 2018
Merged
@faboweb faboweb closed this as completed Jan 8, 2018
@faboweb faboweb added this to the Automatic Signed Setups milestone Feb 27, 2018
faboweb pushed a commit that referenced this issue Jun 2, 2020
@colw @faboweb
colw/subscription-fix (#47)
73c8404 
* Fix transaction destructure

* Lint

* Rename for consistency

* Override method for V2
faboweb added a commit that referenced this issue Jun 2, 2020
@faboweb
Update production (#75)
5a468dc 
* added node install to docker

* run npm install correct

* don't copy modules

* use env variables for testnet

* Update pr.yml

* github workflows changes

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Update pr.yml

* Make search case-insensitive (#36)

Modify variable names for clarity.

* Query balance by denomination (#48)

* colw/subscription-fix (#47)

* Fix transaction destructure

* Lint

* Rename for consistency

* Override method for V2

* Colw/fix denom and votes (#49)

* Use larger denom for governance parameters

* Lint

* Fix: Leave in big number format for line #86

* Fabo/minor fixes (#51)

* gracefully handle no rewards

* always return balance

* prevent error when no rewards

* fix wrong delegation amount showing

* log transaction if tag is empty (#58)

* fix tally for running proposals (#54)

* Fabo/move testnet definition into network configs file (#56)

* move testnet definition into network configs file

* use configs for endpoints

* update cache key per block (#57)

* colw/minor-fixes (#59)

* Export testnet data for use in LunieDB Source

* Fix get query

* Mario/32 add proposal proposer (#52)

* Add proposal proposer

* Add proposer to proposals page

* Revert package.js mod, use Promise.all

* Call all queries at same time in getProposalById

* Api error 500 fix

* Fabo suggestions

* Add cross-env

* Resolve merge conflict

* Fix merge error

* deliver correct testnet url (#60)

* Latest proposal should be on top (#61)

* Colin's magic

* const proposals

* fix to not crash if no denom

* Fabo/wait for stargate to be up (#62)

* debug missing denom

* do not call validators

* await for the remote instance to be up before loading static data

* remove logs

* remove fallback

* comment

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* Update cosmosV0-source.js

* colw/subscription-refactor (#63)

* Factor out subscription object

* WIP

* Reenable subs

* Do not pre-populate cache (temp)

This is run on every request.

* Reenable static data

* Fix

* Remove comment

* WIP

* Use API class within subscription object

* Update file and parameter naming

* Load API classes once.

* Revert "Load API classes once."

ca567095360dbd7a8d81c7a53fe4fe885f3b63d2

* Set headers in separate method

* format comment

* Rename class variable

* Split static data up

* Adjust cache timing, default 5

* Update lib/schema.js

Co-Authored-By: Fabian <[email protected]>

* Change client name to TendermintClient

* Comment and rename for clarity

* Cache specific blocks longer

* Move Tendermint client to CosmosNodeSubscription

* Comments for clarity

* Clear memory after handling each new block (#66)

* Fix typo and no return. (#68)

* Aleksei/sentry added (#67)

* only sentry init code added

* docker-compose changes

* inspect removed

* colw/Decrease validator list loading time (#69)

* Fetch validators each new block and store them

* Store block, and sync validator map with block

* Add block to store

* Remove unused parameters

* Retrieve a single validator form the map

* Review fix: remove height parameter

* Review fix: Change variable name for clarity

* Return delegations and rewards from store (#70)

* Return delegations and rewards from store

* overview values

* Remove unnecessary Promise.all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@faboweb faboweb

Labels
low priority has been discussed, will be addressed later
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@faboweb @jbibla