Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url to pushover notification #5055

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Conversation

aizatto
Copy link
Contributor

@aizatto aizatto commented Aug 27, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

The Pushover API allows an URL to be included in the HTTP Request. This can help for better user experience to quickly open the Uptime Kuma dashboard.

https://pushover.net/api

Type of change

Please delete any options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Before:

image

After:

image

Notice the url is included.

@CommanderStorm CommanderStorm added pr:please address review comments this PR needs a bit more work to be mergable area:notifications Everything related to notifications type:enhance-existing feature wants to enhance existing monitor labels Aug 27, 2024
@CommanderStorm CommanderStorm marked this pull request as ready for review August 28, 2024 01:21
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change to the notification provider! 🎉

Note

This PR is part of the v2.0 merge window => see #4500 for the bugs that need to be addressed before we can ship this release ^^

All changes in this PR are small and uncontroversial ⇒ merging with junior maintainer approval

@CommanderStorm CommanderStorm merged commit 01210ce into louislam:master Aug 28, 2024
18 checks passed
@aizatto
Copy link
Contributor Author

aizatto commented Aug 28, 2024

New screenshot:

image

@CommanderStorm CommanderStorm added this to the 2.0.0 milestone Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications pr:please address review comments this PR needs a bit more work to be mergable type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants