-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.0.0
-Release <- Read this for performance problems
#4500
Comments
This comment was marked as resolved.
This comment was marked as resolved.
@compgeniuses If you want to test-drive or contribute one of the areas named above, our contribution guide should have all the answers. If you are missing something for development, feel free to ping me. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
Closing as |
@CommanderStorm I was looking at the beta, and it is not clear if the "external" MariaDB is included within the uptimeKuma image or (in a context of docker compose) to have uptimeKuma along with a mariadb as a separated containers |
Seems to embedded: uptime-kuma/docker/debian-base.dockerfile Line 69 in 4e144ec
I'd love if we could separate this. |
Setup option let's you choose either embedded or external depending on your preferences/requirements. |
Personally, I'd prefer to either choose between using the embedded SQL-Lite (which we know the limitations in production, but good enough for a testing environment) OR go full power and leave the user running a separated MariaDB offering the following advantages (to my eyes of course):
To summarize: But in general, the peculiarity of docker is the detachment of dependencies so having an image ALL-IN-ONE is in my opinion against this principle |
If you don't want mariadb, please use the
Having all of the features in the default image and having slim variants is quite common. |
@CommanderStorm thanks for the response. |
@CommanderStorm |
@louislam , @CommanderStorm , Thank you in advance for your support. |
Please refer to https://github.com/louislam/uptime-kuma/wiki/Migration-From-v1-To-v2 |
Dear Frank,
I am running Uptime Kuma in a non-Docker environment because I have integrated a custom module into the existing setup and submitted a pull request for these changes.[#5382]
To maintain my customizations, I update and manage the application without Docker. So i want to migrate from v1 to v2 without using Docker.
Here are the steps I follow for setup and execution & updates:
# Update from git
git fetch --all
git checkout 1.23.15 --force
# Install dependencies and prebuilt
npm install --production
npm run download-dist
npm run setup
# Option 1. Try it
node server/server.js
# Start Server
pm2 start server/server.js --name uptime-kuma
Looking for the migration guide without using Docker.
…________________________________
From: Frank Elsinga ***@***.***>
Sent: Monday, December 2, 2024 1:31 PM
To: louislam/uptime-kuma ***@***.***>
Cc: Maryam Saleem ***@***.***>; Comment ***@***.***>
Subject: Re: [louislam/uptime-kuma] `v2.0.0`-Release <- Read this for performance problems (Issue #4500)
You don't often get email from ***@***.*** Learn why this is important<https://aka.ms/LearnAboutSenderIdentification>
Please refer to https://github.com/louislam/uptime-kuma/wiki/Migration-From-v1-To-v2
If anything is missing, feedback is appreciated
—
Reply to this email directly, view it on GitHub<#4500 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BHCBSCYNP3IPPZ2FH756ZEL2DQLGDAVCNFSM6AAAAABDNIX4NKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMJQHA3TSMJWGA>.
You are receiving this because you commented.Message ID: ***@***.***>
|
@CommanderStorm , I am running Uptime Kuma in a non-Docker environment because I have integrated a custom module into the existing setup and submitted a pull request for these changes: To maintain my customizations, I update and manage the application without Docker. So i want to migrate from v1 to v2 without using Docker. Here are the steps I follow for setup and execution & updates:
Looking for the migration guide without using Docker. |
You could build your own Docker image with the patch maybe? Unless you really don't wanna use Docker |
It sounds like you are looking for a development environment. What you are trying to do is otherwise not well supported as it is not the main path. You can test pull requests via this path: https://github.com/louislam/uptime-kuma/wiki/Test-Pull-Requests |
@CommanderStorm , I wanted to let you know that I have already opened a pull request (PR) to contribute to the project. My goal is to enhance Uptime Kuma by adding SIP-related features, and I fully understand that my deployment method is not the standard approach. However, I'm currently running Uptime Kuma using PM2 in a Linux environment, not Docker, and I aim to migrate from v1 to v2 without relying on Docker. I realize this isn't officially supported |
@Wraaath , Could you please clarify what specific patch or adjustments you are referring to? Your advice will help me ensure a smooth migration while aligning with the project’s standards. |
@msaleemCinnova Since you already wrote the code, please just post it. Having a discussion is not quite relevant to adding notification providers or basic (cannot be implemented using current monitors) monitors like the one you are trying to add. I don't know what a SIP is => please preferably include a test case that it works (see the mqtt test cases for examples how this can be done). |
@CommanderStorm , I will add the code to submitted the PR. I’ll respect your preference to keep the process straightforward and will avoid extensive discussions. |
This was originally a PR here, but has been transformed into an issue due to being pin-able
what has been done?
We are hard at work improving Uptime Kuma.
If you want to have a look at the full set of features for
v2.0
, have a look here.Most notably this includes (a full migration guide will be made before the release, dont worry):
=> even though benchmarking is still out, we are confident that this pushes the prominent "limits" (highly hardware-dependent, not a limit imposed by us) ~500 Monitor or ~1.5GB DB-size
A large part of the focus in this release is on performance. We don't know if we are optimising for the right thing, see Can/should we add
privacy-respecting usage metrics
? #4456 for a discussion on this topic.Tip
If you are affected by the performance problems of
v1
, you need to reduce the amount of data you store.The core problem is that Uptime Kuma in
v1
has to do a table scan of the entire heartbeat table for some operations.The solution boils down to having a lower amount of data => making Uptime Kuma less worried about reading those gigabytes of data.:
VACUUM
button under/settings/monitor-history
nscd
) have been dropped CacheableLookup was never used for http monitors #3762what is needed to get
2.0.0-beta.0
releasedNote
We hope
2.0.0-beta.0
can be released in spring 2024, which doesn't include the e2e tests yet. During the beta test, we will try to work on implementing the e2e tests.Tip
How can I get involved?
While most of the bugs noted below require reading some code
=> gaining some context about how the aggregated tables work, some work do not and are such better starting points:
UptimeCalculator
for PingChart #4264)Heartbeat table keeps 24-48 hours data only (excepted for important events, it will keep longer for the event list)(Can be deferred)v1
tov2
(Wiki) Migration Guide from v1 to v2 uptime-kuma-wiki#53customBody
andcustomHeader
via liquidjs #3414vArIaBlE Cased
variablesUPPERCASE
variables (this was added to make thev1
⇒v2
migration more seamless, but will be removed in v3)2.0.0-beta.0
The text was updated successfully, but these errors were encountered: